Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

date rendering issue, get "@@@@~@@@@" #207

Closed
moribellamy opened this issue Feb 6, 2018 · 4 comments
Closed

date rendering issue, get "@@@@~@@@@" #207

moribellamy opened this issue Feb 6, 2018 · 4 comments
Assignees
Milestone

Comments

@moribellamy
Copy link

To repro this issue I just made a github repo, https://github.com/moribellamy/sample-resume-issue.

I hooked it up to travis so that you could know exactly the environment i'm running stuff in. I expect the ./generate.sh script to generate a good looking resume, like this one: (see the dates are properly rendered): https://htmlpreview.github.io/?https://github.com/moribellamy/resume/blob/master/resume.html

However the actual code renders a bad looking resume (see the dates are wonky): https://htmlpreview.github.io/?https://github.com/moribellamy/sample-resume-issue/blob/master/resume.html.

Somehow it works on my local macbook pro though. The way I get the "good looking" resume is to npm install -g hackmyresume, so there must be some difference between my global install and my local, hermetic install. Here is my NPM package list: https://gist.github.com/moribellamy/90b7d1e932073d7be1526ab42e54071f

@hacksalot
Copy link
Owner

hacksalot commented Feb 7, 2018

Thanks for the report and for putting together the reproducible test case. This is fixed in the latest code on dev and should be rolled into the 1.9.0 release, due in the next 48 hours or so.

EDIT: Thanks for putting in the extra effort here. If you'll keep those repos handy I'll see if we can integrate some stuff on the test side.

@hacksalot hacksalot added this to the v1.9.0 milestone Feb 7, 2018
@hacksalot hacksalot self-assigned this Feb 7, 2018
@moribellamy
Copy link
Author

NP, thanks for looking. I'm still seeing the issue at HEAD, I updated the reference repo. https://travis-ci.org/moribellamy/sample-resume-issue.

@hacksalot
Copy link
Owner

hacksalot commented Feb 12, 2018

No problem - try HEAD on the dev branch eg somewhere around 033b29f

@hacksalot
Copy link
Owner

Now fixed in the latest official release, v1.9.0-beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants