Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strange char in generated file #168

Closed
oupala opened this issue Aug 23, 2016 · 2 comments
Closed

strange char in generated file #168

oupala opened this issue Aug 23, 2016 · 2 comments
Assignees
Milestone

Comments

@oupala
Copy link

oupala commented Aug 23, 2016

As discussed in this issue: mudassir0909/jsonresume-theme-elegant#73 hackmyresume is generating some strange char when using the <abbr> feature of jsonresume-theme-elegant.

jsonresume-theme-elegant is using markdown-it as a markdown renderer and everything goes well when using the test procedure.

But when switching to hackmyresume, there is some strange annoying @@@@~ and ~@@@@ strings.

I really don't know where it does come from, except that this does not happens without hackmyresume. That's why I suppose it may come from hackmyresume.

Any tought is welcome!

@hacksalot
Copy link
Owner

hacksalot commented Feb 3, 2018

I am able to reproduce this. There's a cleaner solution in the pipeline for 1.9.0/2.0.0.

The strange characters are lexical guards that allow HackMyResume to perform arbitrary Markdown translation on resumes generated from JSON Resume themes even though JSON Resume doesn't natively support Markdown and most JSON Resume themes aren't Markdown aware (jsonresume-theme-elegant is an exception). Normally they're stripped out of the document but obviously in this case that's not happening.

@oupala
Copy link
Author

oupala commented Feb 27, 2018

I tested a new resume generation with version 1.9.0-beta and it seems to work well.

No more @@@@ in generated files!

I'm hardly waiting for the final release!

-                                                    <p class="text-muted"><small><span class="space-right">@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~Jan~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@, 2006 - @@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~Mar~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@~@@@@, 2010</span><span><i class="icon-clock mr-5"></i>4 years 3 months</span></small>
+                                                    <p class="text-muted"><small><span class="space-right">Jan, 2006 - Mar, 2010</span><span><i class="icon-clock mr-5"></i>4 years 3 months</span></small>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants