Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File output leaves behind supporting files #141

Open
RyenNelsen opened this issue Feb 14, 2016 · 1 comment
Open

File output leaves behind supporting files #141

RyenNelsen opened this issue Feb 14, 2016 · 1 comment

Comments

@RyenNelsen
Copy link

On 255a518 dev, HackMyResume leaves behind supporting files. After running the command hackmyresume build resume.json to resume/resume.all -p phantomjs, and performing a ls, the contents are as shows:

-rw-r--r-- 1 Ryen Ryen   3011 Feb 13 21:49 modern-html.css
-rw-r--r-- 1 Ryen Ryen   3002 Feb 13 21:49 modern-pdf.css
-rw-r--r-- 1 Ryen Ryen  47637 Feb 13 21:49 resume.doc
-rw-r--r-- 1 Ryen Ryen  13963 Feb 13 21:49 resume.html
-rw-r--r-- 1 Ryen Ryen   4344 Feb 13 21:49 resume.json
-rw-r--r-- 1 Ryen Ryen   2126 Feb 13 21:49 resume.md
-rw-r--r-- 1 Ryen Ryen  40919 Feb 13 21:49 resume.pdf
-rw-r--r-- 1 Ryen Ryen   8888 Feb 13 21:49 resume.pdf.html
-rw-r--r-- 1 Ryen Ryen 102910 Feb 13 21:49 resume.png
-rw-r--r-- 1 Ryen Ryen  13963 Feb 13 21:49 resume.png.html
-rw-r--r-- 1 Ryen Ryen   2467 Feb 13 21:49 resume.txt
-rw-r--r-- 1 Ryen Ryen   3925 Feb 13 21:49 resume.yml

I would expect the files modern-pdf.css, resume.pdf.html, and resume.png.html to be removed.

@hacksalot
Copy link
Owner

Three ways to handle this:

  1. Delete the intermediate output files per your suggestion.
  2. Never write the intermediate output files in the first place.
  3. Formally package all the output files.

One advantage to keeping the output files in place is that the user has all the artifacts necessary to re-generate the binary artifacts like PNGs and PDFs etc. But if we're going to do this, we need to think in terms of outputting a formal package (a collection of files) or at least providing a manifest that formally lists the generated files along with some metadata.

@hacksalot hacksalot modified the milestones: v1.9.0, v2.0.0 Feb 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants