Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "window" references from component-library to enable SSR #503

Closed
jaronheard opened this issue May 2, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@jaronheard
Copy link
Contributor

jaronheard commented May 2, 2019

Description

There are references to "window" in the component library. These should be found, and wrapped in if statements, to allow SSR

if (typeof window !== `undefined`) {
  //use window here
}

Steps to reproduce

Run "gatsby build" in this sandbox

Expected result

It should build properly

Actual result

Errors like this:

WebpackError: ReferenceError: window is not defined

Environment

Where are you seeing the error? (Environment details)

@jaronheard
Copy link
Contributor Author

#531

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant