Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support permission of invitee only #35

Open
jackycute opened this issue Oct 2, 2015 · 17 comments
Open

Support permission of invitee only #35

jackycute opened this issue Oct 2, 2015 · 17 comments
Labels
feature Wants to add a new feature

Comments

@jackycute
Copy link
Member

Should support a permission of invitee only.
Only the invitee from email or link can edit the note.

@jackycute jackycute added the enhancement Wants to improvide an existing feature label Jan 19, 2016
@jackycute
Copy link
Member Author

We supported private permission in 49c7dde.
private means only owner can view and edit.

@jackycute
Copy link
Member Author

We supported limied and protected permissions in a8068d3.
limited is similar to editable but forbid guest to view.
protected is similar to locked but forbid guest to view.

@Yukaii Yukaii added this to the Backlog milestone Feb 27, 2017
@jackycute jackycute mentioned this issue Feb 27, 2017
@ccoenen
Copy link
Contributor

ccoenen commented Mar 13, 2017

This list is quite long by now. While I find all the items' names to be very carefully chosen, yet I still have to look up which is which. While permissions are being extended, maybe it's a good idea to revisit how a user sets these permissions. Maybe it's not one long list from "very private" to "very public" but two sliders, one for reading and one for writing. Or something else entirely.

@jackycute
Copy link
Member Author

@ccoenen
So actually we only need to choose one of read or write permission for every invited user.
Not one from current permission types.

@Himura2la
Copy link
Contributor

I'm not quite understand your permission system. If I set limited, does it mean that everyone who is registered on the site can view/edit it?
How can I allow access only to the list of certain persons?

@jackycute
Copy link
Member Author

jackycute commented Mar 29, 2017

We currently have six permissions, I would suggest to read it here: https://hackmd.io/features#permissions

There is no way to allow only for certain people to access note for now.
So this is the issue open for it, and this invitee will be the seventh permission.

@Himura2la
Copy link
Contributor

Thanks, looking forward for having this feature implemented.

@Keeo
Copy link

Keeo commented Sep 13, 2017

Let me add a little bump to this issue. Sadly this missing feature forced me to drop this tool in favor of something else.

@ccoenen
Copy link
Contributor

ccoenen commented Sep 13, 2017

@Keeo Out of curiosity: what alternative are you using?

@Keeo
Copy link

Keeo commented Sep 15, 2017

@ccoenen We downloaded markdown file from hackmd and placed it inside github repository. Collaboration is done thought normal github process and just for rendering use hackmd.

@SISheogorath SISheogorath added feature Wants to add a new feature and removed enhancement Wants to improvide an existing feature labels Oct 6, 2017
@illyas3
Copy link

illyas3 commented Apr 10, 2018

One of the best editors out there, yet one of the worst permission systems. How is this even reasonable to let anyone signed in to edit your notes?

@SISheogorath
Copy link
Contributor

You can change the permission to freely, when you don't want everyone to sign in.

The permission system is mainly grown over time. It definitely needs re-factoring but that also needs time :) If you want to spend some time on the project and work on the permission system, that's definitely an appreciated work.

So feel free to file a PR :)

If you have question or want to talk about concepts feel free to join the Matrix and Gitter community and talk with us.

@ccoenen
Copy link
Contributor

ccoenen commented Apr 10, 2018

It would certainly rock to have something like
"this list of people is allowed"
or
"these five people form a group, that group owns this document"
or
"i can edit, only that group can read"

but somebody has to write that, and currently even something as basic as user accounts is, let's say, very rudimentary. To be honest, I wouldn't expect this any time soon unless somebody picks it up as a pull request.

@gandhiano
Copy link

gandhiano commented Apr 26, 2018

Why not an invite-only link with read and/or write permissions, like it is conventional in many other web tools (e.g. nextcloud)? It is so, that very often there is the need to share documents to review with external people who won't additionally create an account.

They could via such a link just jump in to the document and start editing. And this wouldn't really require an additional permission in the list (I also find they start getting very confusing, as someone commented above), just an option to share a link, e.g. via a button next to Publish. As such, this invite link would work independently from the specific permission settings for the document.

@jaragunde
Copy link

I think that the password feature (#494) could be a workaround for most use cases mentioned here, without making the permission system more complicated.

@RyosukeTakahashi
Copy link

any update on this issue?

It would be superb to have a sharing feature like Google Docs and showing them only to invitees.

@SISheogorath
Copy link
Contributor

No, no changes on that, yet. https://demo.codimd.org/features#Permissions

But we welcome contributions! If you want to help or just talk a bit about it, feel free to join us in our Matrix community: #codimd:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Wants to add a new feature
Projects
None yet
Development

No branches or pull requests

10 participants