Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user administration #272

Open
Joe136 opened this issue Dec 9, 2016 · 13 comments
Open

Add user administration #272

Joe136 opened this issue Dec 9, 2016 · 13 comments
Labels
feature Wants to add a new feature help wanted We want you to help us with this!

Comments

@Joe136
Copy link

Joe136 commented Dec 9, 2016

Hi,
I want to setup a self-hosted instance for a closed group of users. My current solution would be to hide it behind Basic-Auth but allowed users can still create random Accounts. Therefore I need an user administration, meaning only the admin can manage the users

Optional features could be

@jackycute
Copy link
Member

PR welcome 😄

@Braintelligence
Copy link

I would be very happy about the ability to run hackmd self-hosted and private. I don't want everyone to be able to register and use hackmd on my server. Keep up the good work!

@jackycute jackycute mentioned this issue Feb 27, 2017
@Yukaii Yukaii added this to the Backlog milestone Feb 27, 2017
@k0nsl
Copy link

k0nsl commented Apr 14, 2017

@Braintelligence: I agree. At the very least there should be a simple admin UI -- with ability to list all entries and most important of all: a toggle for enabling/disabling a registration feature (eg, an option to enable/disable feature such as registration, where we could have "Registration Required" for private or "Open Registration" for public).

@zeigerpuppy
Copy link

I agree, an option for disabling registration would be really useful.

@SISheogorath
Copy link
Contributor

SISheogorath commented Jun 17, 2017

@zeigerpuppy, there is already a option to disable the registration: HMD_ALLOW_EMAIL_REGISTER

Simply set it to false.

@rriemann
Copy link

I have another idea:

Couldn't there be a setting ENFORCE_EMAIL_DOMAIN=test.local which allows only mail addresses of this domain to register?

@ccoenen
Copy link
Contributor

ccoenen commented Nov 26, 2017

@rriemann's proposal would probably solve most corporate-self-hosted use cases.

@SISheogorath
Copy link
Contributor

SISheogorath commented Nov 26, 2017

Should be easy to manage. You can add an option for that here:

https://github.com/hackmdio/hackmd/blob/8ea09a8bd0a093a802a3fcb2fdac40935fa92f9e/lib/web/auth/email/index.js#L34-L45

And of course in the config directory:
https://github.com/hackmdio/hackmd/tree/master/lib/config

PRs are welcome 😄

@rriemann
Copy link

I think this is really do-able. Unfortunately, I am still stack with getting SSL to work and have to dig into that first. So I hope someone else may be able to step up to solve this already in 2017.

@SISheogorath
Copy link
Contributor

SISheogorath commented Jan 31, 2018

I just want to add some information to this issue:

Thanks to @Nebukadneza's work it's now possible to basically manage email users.

Also it's possible to use an LDAP and SAML backend if you like. From my perspective LDAP or SAML are the better way for closed group setups, since they are stable and actually made for this, while the "local user" feature still feels half-backed and HackMD not designed for it.

We also introduced the possibility to disable the creation of notes by guests while keeping the ability to edit notes, which is maybe useful for these closed group setup when people like to share the pad with some 3rd party.

I want to mention, that HackMD EE has already added and entire user management.

CE will also get one but it probably needs some time, as everything is build during our free time and actually from my side it doesn't have such a focus on it as I disabled all local user management for HackMD on my instances.

Help is really wanted for this, so feel free to discuss, draft and file a PR for it!

@SISheogorath SISheogorath added the help wanted We want you to help us with this! label Jan 31, 2018
@ccoenen
Copy link
Contributor

ccoenen commented Jan 31, 2018

i took the liberty of correcting a tiny but critical typo in your message, @SISheogorath ("not possible" -> "now possible")

@SISheogorath
Copy link
Contributor

👍 Thanks, this was an important fix! I should maybe re-read my texts one more time ^^

@jaswanth098
Copy link

jaswanth098 commented Nov 25, 2019

Hello, Everyone, I have supported allowedDomains for google OAuth
Please check this out and let me know how should I handle the case where some other domain is trying to login. Right now I'm just displaying a string Domain not allowed
ref: jaswanth098#1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Wants to add a new feature help wanted We want you to help us with this!
Projects
None yet
Development

No branches or pull requests

10 participants