-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme #206
Comments
@ArLEquiN64
--- Update --- If you have some idea, feel free to post a screenshot of your mockup, or you can try to apply a global style sheet to see how it works out. |
Does someone know how to load CSS dynamically in webpack, like loading different stylesheet based on config variable? Just tried on this issue but get stuck. Currently, Lepton loads stylesheet like this https://github.com/hackjutsu/Lepton/blob/master/app/containers/userPanel/index.js#L10 |
@hackjutsu you could use dynamic import if (darkTheme) {
import('./dark-theme.scss')
} else {
import('./light-theme.scss')
} but, i think the best way for theming would probably be CSS-variables, you can easily manage it with JS. |
Thanks @DNLHC I created a feature branch https://github.com/hackjutsu/Lepton/tree/feature/dark-theme, but run into the following error
Feel free to play with the code in this branch:) |
@hackjutsu Yeah, the dynamic import has slightly different syntax to the static one, it should be called with parenthesis. |
Some update on this? |
This looks like a good project I can work on this week. I'll keep you guys posted. |
@vviikk Feel free to take a look at the feature/dark-theme branch. |
Hi, @hackjutsu. Could we communicate on Spectrum? I've created a room there. Currently, I'm updating outdated dependencies as I had a bit of trouble getting it to work locally (in Linux & WSL). IIRC, last month I was also having build issues on the Mac. Once I get to build with the latest toolchain (Babel / Webpack), I'll make a PR. Would like to pick your brain about styled-components & it's theme layer and slowly moving out of Bootstrap. |
@vviikk Thanks for creating the chat room. Feel free to leave your questions there, and I'll come back to them within this week. (Sorry, a little bit busy at work for this quarter) |
When this feature will be part of it? dark mode!! |
Working on an early version of dark mode in feature/dark-theme branch. It takes some time to adapt the colors here and there. Stay tuned. |
Wow, awesome! |
I want dark theme like white character and black background.
and if you don't mind, could you support any syntax theme?
The text was updated successfully, but these errors were encountered: