From 2e3bef154c0c3aee41ef67e9f5de7680ea2c3edf Mon Sep 17 00:00:00 2001 From: Tomas Gonzalez Date: Sun, 23 Jan 2022 13:55:24 -0600 Subject: [PATCH 1/4] created an style to the overflow visibility on wins-card attribute. Takes care of the hover effect with the tooltip. --- _sass/components/_wins-page.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/_sass/components/_wins-page.scss b/_sass/components/_wins-page.scss index fc9640a423..9dc61f6ec9 100644 --- a/_sass/components/_wins-page.scss +++ b/_sass/components/_wins-page.scss @@ -202,7 +202,7 @@ display: flex; position: relative; flex-direction: column; - overflow: visible; + overflow: visible !important; } .wins-card-top{ display: flex; From 83b35ee758774034674afc85fc0a3ea642478792 Mon Sep 17 00:00:00 2001 From: Tomas Gonzalez Date: Sun, 23 Jan 2022 14:16:29 -0600 Subject: [PATCH 2/4] Reverted original change. Added 'project-card' styling. Instead of making a global change of '' on the wins-card, I went ahead and added in the '.project-card' class without the overflow style. This makes the '.wins-card' overflow style take precedence, without creating a global '' rule. --- _sass/components/_projects-page.scss | 2 +- _sass/components/_wins-page.scss | 10 +++++++++- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/_sass/components/_projects-page.scss b/_sass/components/_projects-page.scss index bcc1a082f2..7228235da1 100644 --- a/_sass/components/_projects-page.scss +++ b/_sass/components/_projects-page.scss @@ -32,7 +32,7 @@ border-radius: 16px; box-shadow: 0 0 8px 0 rgba($color-black, 0.2); margin-bottom: 24px; - overflow: hidden; + @media #{$bp-tablet-up} { margin-bottom: 0; diff --git a/_sass/components/_wins-page.scss b/_sass/components/_wins-page.scss index 9dc61f6ec9..0284d92950 100644 --- a/_sass/components/_wins-page.scss +++ b/_sass/components/_wins-page.scss @@ -197,12 +197,20 @@ } //card styling +.project-card { + background: $color-white; + border: 0 solid rgba($color-black, 0.06); + border-radius: 16px; + box-shadow: 0 0 8px 0 rgba($color-black, 0.2); + margin-bottom: 24px; +} + .wins-card{ padding: 45px; display: flex; position: relative; flex-direction: column; - overflow: visible !important; + overflow: visible ; } .wins-card-top{ display: flex; From ffeb66f1299dbf04e31bc79df93770c01de733a3 Mon Sep 17 00:00:00 2001 From: Tomas Gonzalez Date: Mon, 31 Jan 2022 15:27:48 -0600 Subject: [PATCH 3/4] added attribute to wins-card this should take care of the overflow once and for all. Just be aware that this will be for effective for ALL wins-card classes. --- _sass/components/_projects-page.scss | 2 +- _sass/components/_wins-page.scss | 11 +---------- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/_sass/components/_projects-page.scss b/_sass/components/_projects-page.scss index 7228235da1..bcc1a082f2 100644 --- a/_sass/components/_projects-page.scss +++ b/_sass/components/_projects-page.scss @@ -32,7 +32,7 @@ border-radius: 16px; box-shadow: 0 0 8px 0 rgba($color-black, 0.2); margin-bottom: 24px; - + overflow: hidden; @media #{$bp-tablet-up} { margin-bottom: 0; diff --git a/_sass/components/_wins-page.scss b/_sass/components/_wins-page.scss index 0284d92950..edfeda1c9c 100644 --- a/_sass/components/_wins-page.scss +++ b/_sass/components/_wins-page.scss @@ -196,21 +196,12 @@ margin: 18px 60px; } -//card styling -.project-card { - background: $color-white; - border: 0 solid rgba($color-black, 0.06); - border-radius: 16px; - box-shadow: 0 0 8px 0 rgba($color-black, 0.2); - margin-bottom: 24px; -} - .wins-card{ padding: 45px; display: flex; position: relative; flex-direction: column; - overflow: visible ; + overflow: visible !important; } .wins-card-top{ display: flex; From 2256dc054e88f52a5e56cd04b96bc3f7a30ed081 Mon Sep 17 00:00:00 2001 From: Tomas Gonzalez Date: Sun, 6 Feb 2022 18:52:21 -0600 Subject: [PATCH 4/4] added overflow visible to project-card-wins-card style in winspage sccss. --- _sass/components/_wins-page.scss | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/_sass/components/_wins-page.scss b/_sass/components/_wins-page.scss index edfeda1c9c..4c900a03be 100644 --- a/_sass/components/_wins-page.scss +++ b/_sass/components/_wins-page.scss @@ -35,6 +35,7 @@ } .project-card.wins-card{ + overflow: visible; @media #{$bp-below-desktop} { margin-bottom: 24px; } @@ -201,7 +202,7 @@ display: flex; position: relative; flex-direction: column; - overflow: visible !important; + overflow: visible; } .wins-card-top{ display: flex;