Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR Template with adding a notice of completing onboarding before creating a PR #7722

Closed
12 of 13 tasks
siyunfeng opened this issue Nov 15, 2024 · 9 comments · Fixed by #7803
Closed
12 of 13 tasks
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@siyunfeng
Copy link
Member

siyunfeng commented Nov 15, 2024

Overview

We have observed non-members creating PRs. To solve this, we will add a notice to the top of the PR template notifying developers that they must complete onboarding before creating a PR.

Action Items

  • Open the file .github/pull_request_template.md in your IDE

  • Add the following text:

    Please note: You must be a member of the HFLA website team in order to create pull requests. Please see our page on how to join us as a member at HFLA: https://www.hackforla.org/getting-started. Delete this message if you joined this team via onboarding.
    <!--  Note: Delete the message above if you joined this team via onboarding  -->
    
    

    above

    <!--  Important! Add the number of the issue you worked on  --> 
    Fixes #replace_this_text_with_the_issue_number
    
  • Push your issue branch to your fork of the website repository, as described in Section 3.1.a of CONTRIBUTING doc, for example: git push --set-upstream origin test-update-labels-1234

  • Save the URL from the push command response, for later use after testing

  • Test the updated PR template by following these steps:

    • Change your default branch to the branch you make the changes on in your repo

      Screenshot of Default Branch Setting

    • Navigate to the Pull Requests tab in your repo, and click the New pull request button

      Screenshot of Pull Requests Tab and New Pull Requests Button

    • Ensure the head repository is your repo and the compare branch is the one you make the changes on, then click the Create pull request button

      Screenshot of Creating Pull Request

    • Verify the appearance of the updated PR template, and compare it with .github/pull_request_template.md
    • Close the Pull Request creation page
  • Complete the Pull Request process by visiting the URL from the push command

  • Submit PR

  • After PR is merged, be sure to follow the step above to change your default branch back to gh-pages

Resources/Instructions

@siyunfeng siyunfeng added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Nov 15, 2024

This comment was marked as resolved.

@siyunfeng siyunfeng added ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization Complexity: Small Take this type of issues after the successful merge of your second good first issue role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly and removed Complexity: Missing role missing Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Nov 16, 2024
@daras-cu daras-cu added size: 0.5pt Can be done in 3 hours or less and removed size: missing ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Nov 20, 2024
@siyunfeng siyunfeng added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Nov 20, 2024
@siyunfeng

This comment was marked as resolved.

@roslynwythe roslynwythe added Ready for Prioritization and removed ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization Ready for Prioritization labels Nov 23, 2024
@siyunfeng siyunfeng added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Nov 23, 2024
@siyunfeng

This comment was marked as resolved.

@roslynwythe

This comment was marked as resolved.

@roslynwythe

This comment was marked as resolved.

@roslynwythe roslynwythe removed the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Nov 23, 2024
@siyunfeng

This comment was marked as duplicate.

@siyunfeng siyunfeng added the ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization label Nov 24, 2024
@roslynwythe roslynwythe added Ready for Prioritization and removed ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Nov 24, 2024
@roslynwythe

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added role: front end Tasks for front end developers and removed Ready for Prioritization labels Nov 26, 2024
@codyjohnsontx codyjohnsontx self-assigned this Dec 13, 2024
@codyjohnsontx codyjohnsontx moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Dec 13, 2024
@HackforLABot
Copy link
Contributor

Hi @codyjohnsontx, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@codyjohnsontx
Copy link
Member

i. Availability: 12/13/2024 12pm - 2pm
ii. ETA: 2pm 12/13/2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Development

Successfully merging a pull request may close this issue.

6 participants