Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Github with GitHub in assets/js/wins.js updateOverlay #7495

Open
7 tasks
Tracked by #7664
daras-cu opened this issue Sep 19, 2024 · 3 comments
Open
7 tasks
Tracked by #7664

Replace Github with GitHub in assets/js/wins.js updateOverlay #7495

daras-cu opened this issue Sep 19, 2024 · 3 comments
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ Ready for Prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@daras-cu
Copy link
Member

daras-cu commented Sep 19, 2024

Overview

We need to replace instances of Github and github with GitHub so that we display the company name correctly, and test the changes to ensure the behavior and appearance of any and all related webpages are unchanged.

Action Items

  • Open assets/js/wins.js in your IDE
  • In function updateOverlay(i) change
  			makeIcon(data[i][github_url], overlayIcons, 'github-icon', '/assets/images/wins-page/icon-github-small.svg', 'Github profile for ' + data[i][name]);

to

  			makeIcon(data[i][github_url], overlayIcons, 'github-icon', '/assets/images/wins-page/icon-github-small.svg', 'GitHub profile for ' + data[i][name]);
  • Find all the files that are connected to this change. (e.g., if its a yml or md file, what files or scripts use the data stored in that file). And document briefly how they work together.
  • Define where you expect the change to show up on the website (e.g., the footer of the website). Can be on multiple pages
  • Write a test procedure, in a comment, and then use it to test the change. Include a link to this comment in your PR.
  • Add/commit changes then create a PR as usual. Document the test procedure in the Pull Request.

Resources

Merge Team

@daras-cu daras-cu added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ size: 1pt Can be done in 4-6 hours labels Sep 19, 2024
@daras-cu daras-cu added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Sep 19, 2024
@ExperimentsInHonesty ExperimentsInHonesty added ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on ready for merge team needs a senior review either to do some re writing or to approve it for ready for prioritization labels Sep 24, 2024
@izma-mujeeb izma-mujeeb self-assigned this Sep 25, 2024
@izma-mujeeb izma-mujeeb moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Sep 25, 2024
@HackforLABot

This comment was marked as outdated.

@izma-mujeeb izma-mujeeb removed their assignment Oct 1, 2024
@izma-mujeeb izma-mujeeb moved this to Prioritized backlog in P: HfLA Website: Project Board Oct 1, 2024
@Kle012 Kle012 self-assigned this Oct 1, 2024
@Kle012 Kle012 moved this from Prioritized backlog to In progress (actively working) in P: HfLA Website: Project Board Oct 1, 2024
@HackforLABot HackforLABot moved this from In progress (actively working) to New Issue Approval in P: HfLA Website: Project Board Oct 1, 2024
@HackforLABot

This comment was marked as resolved.

@HackforLABot
Copy link
Contributor

Hello @dvernon5, we appreciate you taking on this issue, however it looks like you're already working on another issue at this time. Please wait until your current issue is merged before taking on another issue. :)

We are going to unassign you from this issue so you can focus on your current issue.

Hfla appreciates you! :)

@HackforLABot HackforLABot moved this from Prioritized backlog to New Issue Approval in P: HfLA Website: Project Board Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ Ready for Prioritization role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Status: New Issue Approval
Development

No branches or pull requests

6 participants