Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ER: Fix credits text alignment #5938

Open
3 of 6 tasks
JessicaLucindaCheng opened this issue Nov 28, 2023 · 4 comments
Open
3 of 6 tasks

ER: Fix credits text alignment #5938

JessicaLucindaCheng opened this issue Nov 28, 2023 · 4 comments
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Dependency An issue is blocking the completion or starting of another issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic manual dependency release P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Nov 28, 2023

Dependency

  • If removing or adding a field to a credit on the Credits page and there are alignment issues caused by the credit's text recentering vertically

Emergent Requirement - Problem

On the Credits page, we may want to remove the Provider field from some credits for composite images but removing a field may cause some alignment issues.

To test what it would look like if there was no Provider field for some of the credits, I temporarily removed the Provider field from the following credits:

  • Avatar
  • Book
  • Building
  • Button
  • Candidates
  • Employees
  • Environmental Impact

The result was it recenters the text vertically and doesn't look good because, in desktop view, the tops of each credit's text are not aligned with each other (i.e. Agile and Avatar credits; Calendar Time and Candidates).

Click here to see a screenshot marked up with red horizontal lines showing how the tops of the texts for Agile and Avatar credits and the tops of the texts for Calendar Time and Candidates are not aligned. agile, avatar, calendar, candidates with line

For reference, here are full-page screenshots of the Provider field removed from some of the credits:

Click to see desktop view

credits-no-provider

Click to see mobile view

credits-no-provider-mobile

Issue you discovered this emergent requirement in

Date discovered

May 9, 2023

Did you have to do something temporarily

  • YES
  • NO

Who was involved

@JessicaLucindaCheng
@ExperimentsInHonesty

What happens if this is not addressed

If the Provider field is removed, the credits text is recentered vertically and doesn't look good.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

Align each credit's text so it starts at the top of its flex container for each credit, add align-self: flex-start; to the .icon-info class in _sass/components/_credit-items.scss.

  • Note: This does not align the text with the top of the images because the images are centered vertically and the images are different heights (i.e. Citizen Engagement credit image).

Here are screenshots of what adding align-self: flex-start; to the .icon-info class would look like

Click here to see desktop view

credits-align-self

Click here to see mobile view

credits-align-self-mobile

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature Missing This label means that the issue needs to be linked to a precise feature label. Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Missing labels Nov 28, 2023
@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Nov 28, 2023

This comment was marked as resolved.

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added P-Feature: Credit https://www.hackforla.org/credits/ Issue Making: Level 2 Make issue(s) from an ER or Epic Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Nov 28, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Dependency An issue is blocking the completion or starting of another issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic manual dependency release P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

No branches or pull requests

2 participants