Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run VS Code Spell Checker on _includes/sponsors.html #5599

Closed
8 of 9 tasks
Tracked by #5248
roslynwythe opened this issue Sep 26, 2023 · 9 comments
Closed
8 of 9 tasks
Tracked by #5248

Run VS Code Spell Checker on _includes/sponsors.html #5599

roslynwythe opened this issue Sep 26, 2023 · 9 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Administrative Administrative chores etc. feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Sep 26, 2023

Overview

We need to audit HfLA codebase files for spelling errors using the Code Spell Checker extension in VS Code in order to ensure site quality. Results will be categorized as misspellings or false positives in the HfLA spelling audit spreadsheet1 and will be resolved in later issues.

Action Items

  • You must use VS Code as your local text editor and install the Code Spell Checker VS Code extension2
  • Do not change any configuration settings or make any spell corrections
  • Open the file '_includes/sponsors.html' and note any Code Spell Checker errors
  • Locate the file in column A ("File") of the "Page Audit" sheet. In the column labeled "Result Summary", select the appropriate option: No errors or At least one error.
  • If at least one error was reported, copy/paste each cSpell message into a separate row in the Results sheet
  • In each new row, select the appropriate value: misspelling or false positive from the "Result type" column. A false positive is a term that is not a misspelling but is not recognized by the spell checker because it is a technical term, abbreviation, acronym, URL or proper noun (name of a person, place or organization).
  • Move this issue to the Questions/In Review column and apply the label ready for dev lead

Merge Team

Resources/Instructions

Footnotes

  1. HfLA spelling audit spreadsheet - Results

  2. The recommended installation method is to install Code Spell Checker directly from the VS Code text editor, and those instructions can be found here. The extension can also be installed via the VS Code Marketplace website here.

@roslynwythe roslynwythe added Feature: Administrative Administrative chores etc. role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Sep 26, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Sep 26, 2023
@GRK1998 GRK1998 self-assigned this Sep 27, 2023
@github-actions

This comment was marked as resolved.

@GRK1998

This comment was marked as resolved.

@t-will-gillis
Copy link
Member

Hi @GRK1998 You have an outstanding PR that needs your attention #5417 fixes 5167 and this needs to be completed before starting another issue.

Also, both this issue and the open PR are for Complexity: Small issues. As noted in the "Pre-work Checklist" devs should have completed 2 good first issues prior to starting a small issue, and then each dev should progress from small to medium to large issues.

Un-assigning you from this issue. Please complete the open PR. Thanks

@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Hi @freaky4wrld, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@freaky4wrld
Copy link
Member

Availability: Thursday (12th Oct 2023) evening mostly after 6PM
ETA: Friday (13th Oct 2023) EOD

@freaky4wrld freaky4wrld added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 11, 2023
@freaky4wrld
Copy link
Member

Hey there, False Positive found in the specified file and are added to valid sheets as follows:

  • Pages-Audit Sheet : at line/row 25 (_includes/sponsors.html)
  • Result Sheet : at line/row 32 and 33 (_includes/sponsors.html)

@LRenDO
Copy link
Member

LRenDO commented Oct 11, 2023

Hi @freaky4wrld! Great job with this issue! It looks like there are the same errors on this page on my end too! You also did a great job with moving the issue to the right column and adding the correct label. I have one small request. Can you please separate out each instance of "Sonder". Once you've done that you can ping me here and re-add the read for dev lead label and I will go ahead and approve it. Thanks!

@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 11, 2023
@freaky4wrld
Copy link
Member

@LRenDO I've separated the instances of Sonder now, now the added lines are at line/row 32, 33 and 34 in the Result Sheet

Thanks for the suggestion to separate them.

@freaky4wrld freaky4wrld added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 12, 2023
@LRenDO
Copy link
Member

LRenDO commented Oct 12, 2023

Hi @freaky4wrld! Looks great! Thanks for making the update!

@LRenDO LRenDO closed this as completed Oct 12, 2023
@LRenDO LRenDO removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Administrative Administrative chores etc. feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

6 participants