Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor HTML: _includes/about-page/about-card-platform.html - Workforce Development #5365

Closed
5 tasks done
Tracked by #5279
roslynwythe opened this issue Aug 30, 2023 · 10 comments · Fixed by #6292
Closed
5 tasks done
Tracked by #5279
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 30, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to update an HTML tag to resolve the linter error "Tag must be paired; missing </span>"

Action Items

  • In your local IDE, navigate to _includes/about-page/about-card-platform.html
  • Change the line of code
            <div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/workforce-development.svg" alt=""></span><span class="sub-head-text color-dodgerblue">Workforce Development</div>

to

            <div class="sub-card-head"><span class="sub-head-image"><img src="/assets/images/about/platform-header-elements/workforce-development.svg" alt=""></span><span class="sub-head-text color-dodgerblue">Workforce Development</span></div>
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 1 in the Resources/Instructions section below)

Merge Team

@roslynwythe this is the last issue in this epic.  Please add the following to the next PM/Dev agenda
```
- [ ] BW: we are finished with this epic, do we need to re-run the linter to see if there are any additional HTML errors it catches?
```

Resources/Instructions

  1. Webpage(s): https://www.hackforla.org/about
  2. This issue is tracked in HfLA-Website: HTML linter audit spreadsheet, and Epic: Create Issues to Fix HTML linter errors #5279
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 30, 2023
@github-actions

This comment was marked as outdated.

@roslynwythe roslynwythe added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Feature: Refactor HTML and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 30, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Aug 30, 2023
@angela-lee1 angela-lee1 self-assigned this Feb 11, 2024
Copy link

Hi @awlFCCamp, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@angela-lee1
Copy link
Member

Availability: 2/13 6pm-10pm
ETA: 2/15 EOD

@ExperimentsInHonesty
Copy link
Member

@awlFCCamp I have unassigned you from this issue (because you already have done two good first issues and need to move on to a small size issue. I have reopened your prework where I will send you a link to find a new issue.

Copy link

Hi @evan-ishibashi, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@evan-ishibashi
Copy link
Member

Availability for this week: 2/13 5pm - 7pm
My estimated ETA for completing this issue: 2/13
(commenting after the pr was made)

@evan-ishibashi
Copy link
Member

How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?
1 Hour to get to the first good issue, about to head into the 1 hour meeting soon

@angela-lee1
Copy link
Member

angela-lee1 commented Feb 14, 2024 via email

@evan-ishibashi
Copy link
Member

@awlFCCamp
I realize that the estimate needs more context. I completed a lot of the earlier steps during the onboarding meeting, which took a couple of hours. I've also had prior experience with git and github branching, so that might have taken less time. So realistically it probably is closer to 2 - 3 in total. I was just estimating the time it took when I started working on the checklist. thanks

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Feb 16, 2024

Evan is assigned to this issue. So its his issue. All other comments are irrelevant. @awlFCCamp please unsubscribe to this issue so that you don't keep getting notifications for it. Open the issue, and click un ubsubscribe button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
4 participants