Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img Tag Refactor: _includes/events-page/our-locations-content.html - southla.png #5265

Closed
4 of 5 tasks
Tracked by #5040
roslynwythe opened this issue Aug 20, 2023 · 5 comments · Fixed by #5442
Closed
4 of 5 tasks
Tracked by #5040
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 20, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • #5270
  • Remove the ending slash in the img HTML tag by changing
<img class="location-image" src="../assets/images/hack-nights/southla.png" alt="South L.A."  />

to

<img class="location-image" src="../assets/images/hack-nights/southla.png" alt="South L.A.">
  • The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Merge Team

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/_includes/events-page/our-locations-content.html
  2. Webpage(s): https://www.hackforla.org/events/
  3. This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, and Epic: Create Issues for removing closing slash from img tags #5040
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 20, 2023
@github-actions
Copy link

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added good first issue Good for newcomers P-Feature: Events https://www.hackforla.org/events/ Feature: Refactor HTML size: 0.25pt Can be done in 0.5 to 1.5 hours role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 20, 2023
@roslynwythe roslynwythe added this to the x. Technical debt milestone Aug 20, 2023
@roslynwythe roslynwythe changed the title img Tag Refactor: _includes/events-page/our-locations-content.html - Westside1.png img Tag Refactor: _includes/events-page/our-locations-content.html - southla.png Aug 20, 2023
@tkozek tkozek self-assigned this Aug 20, 2023
@github-actions
Copy link

Hi @tkozek, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@bluechocolate2019 bluechocolate2019 self-assigned this Aug 21, 2023
@github-actions
Copy link

Hi @bluechocolate2019, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@bluechocolate2019 bluechocolate2019 removed their assignment Aug 21, 2023
@github-actions github-actions bot added the To Update ! No update has been provided label Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

@tkozek

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, August 29, 2023 at 12:06 AM PST.

@tkozek
Copy link
Member

tkozek commented Sep 4, 2023

Progress: I just need to check the website changes in docker, and sync my project with the main project
Blockers: I am having great difficulty setting up docker
Availability: 6
ETA: As soon as I can verify with docker.

@tkozek tkozek added Status: Updated No blockers and update is ready for review Blockers and removed To Update ! No update has been provided Status: Updated No blockers and update is ready for review labels Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Events https://www.hackforla.org/events/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants