Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img Tag Refactor: _includes/about-page/about-card-sustainability.html - sdg11.svg #5175

Closed
4 tasks done
Tracked by #5040
roslynwythe opened this issue Aug 9, 2023 · 4 comments · Fixed by #5401
Closed
4 tasks done
Tracked by #5040
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Aug 9, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • In your local IDE, navigate to _includes/about-page/about-card-sustainability.html
  • Remove the ending slash in the img HTML tag by changing
<img src="/assets/images/sdg/sdg11.svg" alt="11 Sustainable Cities and Communities" />

to

<img src="/assets/images/sdg/sdg11.svg" alt="11 Sustainable Cities and Communities">
  • The file may contain more than one instance of an img tag with a closing slash. Only change the single instance specified above. Do not leave any blank spaces before the closing bracket.
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Resources/Instructions

  1. For QA to validate change: https://github.com/hackforla/website/blob/gh-pages/assets/js/current-projects.js
  2. Webpage(s): https://www.hackforla.org/about
  3. This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of Rollout Plan: Refactor code with img HTML tags to end without a slash #4362
@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

@roslynwythe roslynwythe added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours P-Feature: About Us https://www.hackforla.org/about/ Feature: Refactor HTML Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 9, 2023
@wanyuguan wanyuguan added this to the x. Technical debt milestone Aug 12, 2023
@WayneTsai45 WayneTsai45 self-assigned this Aug 22, 2023
@github-actions

This comment was marked as outdated.

@github-actions
Copy link

Hi @bluechocolate2019, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@bluechocolate2019
Copy link
Member

Availability: Thursday, Aug 31 & Monday, Sept 4
ETA: Monday, Sept 4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: About Us https://www.hackforla.org/about/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants