Audit for img tags ending with a slash in file: _layouts/project.html

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags. In this issue we will audit a single code file for all instances of img HTML tags ending with a slash, and will record each instance found in a spreadsheet.

Action Items

• Open the sheet HfLA-Website: img Tag Audit spreadsheet¹
• In your local IDE, navigate to Resource²
• Audit Resource² to find any and all instances of img HTML tags ending with a slash (<img.../>)
• For each instance found in Resource², create a new row in the img with Ending Slash sheet
  • Enter _layouts/project.html into the Path to file column of the spreadsheet
  • Copy the img tag (with brackets) into the Line of Current Code column
• After all instances have been recorded in the sheet, add the ready for dev lead label to this issue and move it to the Questions/In Review column

For merge team/dev lead

• After reviewing the issue
  • Remove the ready for dev lead label and close the issue.
  • Open Epic: Create Issues to audit codebase for img tags ending with a slash #4922 and check off this issue in the Dependencies section.

Resources/Instructions

This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab and resulted from Epic #4922 and Rollout #4362

Footnotes

1. HfLA-Website: img Tag Audit (Roll out plan #4362) ↩

2. _layouts/project.html ↩ ↩² ↩³

[github-actions]

Hi @roslynwythe.

Please don't forget to add the proper labels to this issue. Currently, the labels for the following are missing:
Complexity, Role, Feature

NOTE: Please ignore the adding proper labels comment if you do not have 'write' access to this directory.

To add a label, take a look at Github's documentation here.

Also, don't forget to remove the "missing labels" afterwards.
To remove a label, the process is similar to adding a label, but you select a currently added label to remove it.

After the proper labels are added, the merge team will review the issue and add a "Ready for Prioritization" label once it is ready for prioritization.

Additional Resources:

• Wiki: How to create issues
• Wiki: How to read and interpret labels

[github-actions]

Hi @MattChau01, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[MattChau01]

i. Availability: Wednesday/Thursday & both weekends if need be.
ii. ETA: EoD Saturday, otherwise, will aim to have completed by Friday EoD.

[MattChau01]

Hi @roslynwythe , I've located 2 instances of <img> tags that have a forward slash /> at the end of the tags and already recorded them on the HfLA-Website: img Tag Audit sheet on lines 93 and 94.

Per the directions on the issue, I am to "add the ready for dev lead label to this issue and move it to the Questions/In Review column". Will I need to directly update the lines of code and commit the updated code as well? Or just add the label and move project boards?

[roslynwythe]

Thank you @MattChau01 for providing the requested information. We will be creating new good first issues for updating the html. This issue will be closed as completed.