Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for img tags ending with a slash in file: pages/credits.html #4955

Closed
6 of 10 tasks
Tracked by #4922
roslynwythe opened this issue Jul 17, 2023 · 3 comments
Closed
6 of 10 tasks
Tracked by #4922
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jul 17, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags. In this issue we will audit a single code file for all instances of img HTML tags ending with a slash, and will record each instance found in a spreadsheet.

Action Items

  • Open the sheet HfLA-Website: img Tag Audit spreadsheet1
  • In your local IDE, navigate to Resource2
  • Audit Resource2 to find any and all instances of img HTML tags ending with a slash (<img.../>)
  • For each instance found in Resource2, create a new row in the img with Ending Slash sheet
    • Enter pages/credits.html into the Path to file column of the spreadsheet
    • Copy the img tag (with brackets) into the Line of Current Code column
  • After all instances have been recorded in the sheet, add the ready for dev lead label to this issue and move it to the Questions/In Review column

For merge team/dev lead

Resources/Instructions

This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab and resulted from Epic #4922 and Rollout #4362

Footnotes

  1. HfLA-Website: img Tag Audit (Roll out plan #4362)

  2. pages/credits.html 2 3

@roslynwythe roslynwythe added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less labels Jul 17, 2023
@roslynwythe roslynwythe added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Jul 17, 2023
@roslynwythe roslynwythe self-assigned this Jul 18, 2023
@roslynwythe roslynwythe added the Draft Issue is still in the process of being created label Jul 18, 2023
@github-actions
Copy link

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe roslynwythe removed the Draft Issue is still in the process of being created label Jul 18, 2023
@roslynwythe roslynwythe self-assigned this Aug 6, 2023
@github-actions
Copy link

github-actions bot commented Aug 6, 2023

Hi @roslynwythe, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe
Copy link
Member Author

Populated row 58 in spreadsheet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor HTML role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

No branches or pull requests

2 participants