-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor "No Results" Message from the Toolkit Filter and Reuse it for the Projects Filter #4903
Comments
This comment was marked as outdated.
This comment was marked as outdated.
@chrismenke45 It seems like this issue is to copy the code from the toolkit page and make some changes to it. What we should be doing is making an issue to refactor the code so that it can work for the toolkit page (and any other page) by calling a file that has the specific page variables in it. (filter names, messages, etc.). Once this refactor is done, then this issue can be revised to setup the file for this page with its variables in it. And then call the script with the variable file to deliver a customized result to this page. |
This comment was marked as outdated.
This comment was marked as outdated.
I am taking a break from HFLA and will not be able to complete writing this issue. |
Reopening this issue for ER #4769 and moving it back into the new issue approval column |
Hi @bphan002, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: August 15th Tuesday |
Updated ETA: August 23rd Underestimated complexity |
Overview
The Projects Filter shifts to the center when no results are found by the filter. We need to add a "No Results" message so this shift does not occur.
Details
The Toolkit page filter displays a "no results" message when no results are found by the filter. The code from
toolkit.js
will need to beOnce the above is performed, the code can then be imported into the projects filter file (or any future filter file).
Current Functionality
Desired Functionality
Action Items
toolkit.js
into a new file. Create the new file in the_includes
directory.toolkit.js
into a new file. Create the new file in theelements
directory (path:/assets/js/elements
).Resources/Instructions
The text was updated successfully, but these errors were encountered: