Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor "No Results" Message from the Toolkit Filter and Reuse it for the Projects Filter #4903

Closed
8 tasks done
chrismenke45 opened this issue Jun 30, 2023 · 8 comments · Fixed by #5298
Closed
8 tasks done
Assignees
Labels
Complexity: Extra Large P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@chrismenke45
Copy link
Member

chrismenke45 commented Jun 30, 2023

Overview

The Projects Filter shifts to the center when no results are found by the filter. We need to add a "No Results" message so this shift does not occur.

Details

The Toolkit page filter displays a "no results" message when no results are found by the filter. The code from toolkit.js will need to be

  • extracted into a new component/ element file
  • refactored so that it can be reused on the projects and toolkit filters (or any future filter)

Once the above is performed, the code can then be imported into the projects filter file (or any future filter file).

Current Functionality

Screen Shot 2023-07-01 at 7 23 48 AM

Desired Functionality

Screen Shot 2023-07-01 at 7 25 15 AM

Action Items

  • Extract the HTML code from toolkit.js into a new file. Create the new file in the _includes directory.
    • Style the HTML as needed to match the design in Figma. The "no results" message should look the same on any page.
  • Extract the "no results" JS code from toolkit.js into a new file. Create the new file in the elements directory (path: /assets/js/elements).
  • Refactor the "no results" code so that it
    • functions similarly to the filter on the toolkit page when no results are found
    • can be reused on the home, projects, and toolkit pages
  • Refactor the filter code on the home, projects, and toolkit pages as needed to get the "no results" code to work
  • Import/ include the code in the relevant filter files for the home, projects, and toolkit pages.

Resources/Instructions

@chrismenke45 chrismenke45 added role: front end Tasks for front end developers Complexity: Large P-Feature: Projects page https://www.hackforla.org/projects/ size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Jun 30, 2023
@chrismenke45

This comment was marked as outdated.

@chrismenke45 chrismenke45 added ready for product time sensitive Needs to be worked on by a particular timeframe and removed Draft Issue is still in the process of being created labels Jul 2, 2023
@ExperimentsInHonesty
Copy link
Member

@chrismenke45 It seems like this issue is to copy the code from the toolkit page and make some changes to it.

What we should be doing is making an issue to refactor the code so that it can work for the toolkit page (and any other page) by calling a file that has the specific page variables in it. (filter names, messages, etc.).

Once this refactor is done, then this issue can be revised to setup the file for this page with its variables in it. And then call the script with the variable file to deliver a customized result to this page.

@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed ready for product labels Jul 2, 2023
@chrismenke45

This comment was marked as outdated.

@chrismenke45 chrismenke45 added Draft Issue is still in the process of being created Complexity: Medium and removed Complexity: Large labels Jul 2, 2023
@chrismenke45
Copy link
Member Author

I am taking a break from HFLA and will not be able to complete writing this issue.

@Adastros
Copy link
Member

Reopening this issue for ER #4769 and moving it back into the new issue approval column

@Adastros Adastros reopened this Jul 19, 2023
@Adastros Adastros removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jul 19, 2023
@Adastros Adastros changed the title Add "No Results" to Project Filters Projects and Toolkit Page: Refactor and Add "No Results" Message to Filter Jul 19, 2023
@Adastros Adastros changed the title Projects and Toolkit Page: Refactor and Add "No Results" Message to Filter Refactor "No Results" Message from the Toolkit filter and Reuse it for the Project Filter Jul 19, 2023
@Adastros Adastros changed the title Refactor "No Results" Message from the Toolkit filter and Reuse it for the Project Filter Refactor "No Results" Message from the Toolkit Filter and Reuse it for the Project Filter Jul 19, 2023
@Adastros Adastros changed the title Refactor "No Results" Message from the Toolkit Filter and Reuse it for the Project Filter Refactor "No Results" Message from the Toolkit Filter and Reuse it for the Projects Filter Jul 19, 2023
@Adastros Adastros added Complexity: Large P-Feature: Toolkit https://www.hackforla.org/toolkit/ and removed Complexity: Medium labels Jul 19, 2023
@Adastros Adastros added P-Feature: Home page https://www.hackforla.org/ size: 2pt Can be done in 7-12 hours and removed size: 1pt Can be done in 4-6 hours labels Jul 19, 2023
@Josiah-O Josiah-O added this to the 03.02 Onboarding flow milestone Jul 22, 2023
@Adastros Adastros added Ready for Prioritization and removed Draft Issue is still in the process of being created labels Aug 1, 2023
@bphan002 bphan002 self-assigned this Aug 13, 2023
@github-actions
Copy link

Hi @bphan002, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@bphan002
Copy link
Member

Availability: August 15th Tuesday
ETA: August 19th Saturday

@bphan002
Copy link
Member

Updated ETA: August 23rd

Underestimated complexity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Extra Large P-Feature: Home page https://www.hackforla.org/ P-Feature: Projects page https://www.hackforla.org/projects/ P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

6 participants