Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change h2 margin on Privacy Policy Page #4864

Closed
2 tasks done
chrismenke45 opened this issue Jun 20, 2023 · 3 comments · Fixed by #4945
Closed
2 tasks done

Change h2 margin on Privacy Policy Page #4864

chrismenke45 opened this issue Jun 20, 2023 · 3 comments · Fixed by #4945
Assignees
Labels
Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Milestone

Comments

@chrismenke45
Copy link
Member

chrismenke45 commented Jun 20, 2023

Overview

The h2 selector in _sass/components/_privacy-policy.scss applies a rule to the margin property that is being applied to all <h2> elements in the HFLA website. We need to change this so the styling only affects the <h2> elements privacy policy page.

Action Items

  • Update lines 52-54 (within the @media #{$bp-desktop-up}) in the scss file to only target <h2> elements on the privacy policy page
  • Review the other pages on the site to confirm the change didn't affect any other pages in a negative way.

Resources/Instructions

@chrismenke45 chrismenke45 added role: front end Tasks for front end developers Complexity: Medium P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe P-Feature: Join Page https://www.hackforla.org/join P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Jun 20, 2023
@chrismenke45

This comment was marked as outdated.

@github-actions
Copy link

github-actions bot commented Jul 7, 2023

Hi @angelenelm, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@angelenelm
Copy link
Member

  • Availability: Mon-Fri, 12PM-5PM PST
  • ETA: EOD Friday July 14th

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Join Page https://www.hackforla.org/join P-Feature: Privacy Policy https://www.hackforla.org/privacy-policy P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

3 participants