Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project page to fix any formatting issues with new tools data format #4859

Closed
4 tasks done
Tracked by #4777
ronaldpaek opened this issue Jun 19, 2023 · 2 comments · Fixed by #4897
Closed
4 tasks done
Tracked by #4777

Refactor project page to fix any formatting issues with new tools data format #4859

ronaldpaek opened this issue Jun 19, 2023 · 2 comments · Fixed by #4897
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe

Comments

@ronaldpaek
Copy link
Member

ronaldpaek commented Jun 19, 2023

Dependency

Overview

This task involves refactoring the code referencing page.tools to align with the newly implemented data format for tools. The modifications aim to ensure correct display, accommodating spaces in the new data structure.

Action Items

  • Refer to project.html and locate where tools is being referenced
  • Refactor this code since tools till now be an Array so we need to map over every value
{% if page.tools %}<p><strong>Tools: </strong>{{ page.tools }}</p>{% endif %}

to

{% if page.tools %}
<p id='tools'>
    <strong>Tools: </strong>
    {% for tool in page.tools %}
    {{ tool }}{% if forloop.last == false %},{% endif %}
    {% endfor %}
</p>
{% endif %}

Making this change will ensure tools section renders correctly with the new data format of tools

  • Once the change is made, confirm that Tools data is rendering correctly/ as before on individual project pages.
Click here to see pictures of the tools list

Resources/Instructions

@ronaldpaek ronaldpaek added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing Draft Issue is still in the process of being created role: front end Tasks for front end developers Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages size: 0.5pt Can be done in 3 hours or less P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Complexity: Small Take this type of issues after the successful merge of your second good first issue time sensitive Needs to be worked on by a particular timeframe and removed Complexity: Missing Draft Issue is still in the process of being created Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing labels Jun 19, 2023
@ronaldpaek ronaldpaek changed the title Refactor project.html page located in _layouts folder Refactor project page to fix any formatting issue with new tools data Jun 19, 2023
@ronaldpaek ronaldpaek changed the title Refactor project page to fix any formatting issue with new tools data Refactor project page to fix any formatting issues with new tools data format Jun 19, 2023
@ldietz08 ldietz08 self-assigned this Jun 27, 2023
@github-actions
Copy link

Hi @ldietz08, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@ldietz08
Copy link
Member

Availability: M-F 4pm-6pm
ETA: 6/29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

4 participants