Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ER: Change paragraph in header section from h2 to p HTML tag #4752

Closed
1 of 3 tasks
JessicaLucindaCheng opened this issue May 29, 2023 · 3 comments
Closed
1 of 3 tasks

ER: Change paragraph in header section from h2 to p HTML tag #4752

JessicaLucindaCheng opened this issue May 29, 2023 · 3 comments
Assignees
@gaylem
Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Events https://www.hackforla.org/events/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Milestone
w. Accessibility

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented May 29, 2023 •
edited
Loading

Note: This issue came from the Task List Dev Leads.

Emergent Requirement - Problem

In _includes/events-page/header-container-content.html, the paragraph in the header section is a h2 header but should be a p HTML element.

website/_includes/events-page/header-container-content.html

Lines 5 to 9 in 3a5c147

<h2 class="header-desc">
Hack for LA was incubated in the Code for America Brigade Network and continues the valuable work under Civic Tech Structure,
Inc. a network of civic-minded technologists who contribute their skills toward using the web as a platform for local government
and community service.
</h2>

Who was involved

What happens if this is not addressed

The Events page doesn't follow W3C accessibility guidelines.

Resources

Recommended Action Items

  • Make a new issue
  • Discuss with team
  • Let a Team Lead know

Potential solutions [draft]

For _includes/events-page/header-container-content.html, write an issue for changing the paragraph in the header section from using h2 (<h2 class="header-desc">...</h2>) to p HTML tag on the Events webpage.
@JessicaLucindaCheng JessicaLucindaCheng added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: 0.25pt Can be done in 0.5 to 1.5 hours Draft Issue is still in the process of being created role: front end Tasks for front end developers P-Feature: Events https://www.hackforla.org/events/ and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing labels May 29, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER from TLDL: [replace with info ] ER from TLDL: Change paragraph in header section from h2 to p HTML tag May 30, 2023
@JessicaLucindaCheng JessicaLucindaCheng mentioned this issue Jun 4, 2023
Closed
16 tasks
@ExperimentsInHonesty ExperimentsInHonesty added this to the w. Accessibility milestone Jun 4, 2023
@anjolaaoluwa anjolaaoluwa added ready for dev lead Issues that tech leads or merge team members need to follow up on time sensitive Needs to be worked on by a particular timeframe and removed Complexity: Missing labels Aug 6, 2023
@JessicaLucindaCheng JessicaLucindaCheng added ER Emergent Request ready for product Complexity: Small Take this type of issues after the successful merge of your second good first issue ready for dev lead Issues that tech leads or merge team members need to follow up on Issue Making: Level 2 Make issue(s) from an ER or Epic and removed Draft Issue is still in the process of being created ready for dev lead Issues that tech leads or merge team members need to follow up on Complexity: Extra Large ready for product labels Oct 17, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

Sign in to view
@JessicaLucindaCheng JessicaLucindaCheng added ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 23, 2023
@JessicaLucindaCheng JessicaLucindaCheng mentioned this issue Oct 23, 2023
Open
2 tasks
@JessicaLucindaCheng JessicaLucindaCheng added ready for dev lead Issues that tech leads or merge team members need to follow up on Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level ready for issue making and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Oct 24, 2023
@JessicaLucindaCheng JessicaLucindaCheng changed the title ER from TLDL: Change paragraph in header section from h2 to p HTML tag ER: Change paragraph in header section from h2 to p HTML tag Feb 7, 2024
@gaylem gaylem self-assigned this Apr 12, 2024
@github-actions GitHub Actions
Copy link

Hi @gaylem, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@gaylem
Copy link
Member

gaylem commented Apr 13, 2024 •
edited by ExperimentsInHonesty
Loading

@gaylem gaylem closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gaylem gaylem

Labels
Complexity: See issue making label See the Issue Making label to understand the issue writing difficulty level Complexity: Small Take this type of issues after the successful merge of your second good first issue ER Emergent Request Issue Making: Level 2 Make issue(s) from an ER or Epic P-Feature: Events https://www.hackforla.org/events/ role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
w. Accessibility
Development

No branches or pull requests
5 participants
@JessicaLucindaCheng @ExperimentsInHonesty @gaylem @Josiah-O @anjolaaoluwa