Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labels: Issue Template: suggest-an-external-resource #4476

Closed
3 of 6 tasks
Tracked by #4307
Sebster3 opened this issue Apr 12, 2023 · 4 comments · Fixed by #4674
Closed
3 of 6 tasks
Tracked by #4307

Update labels: Issue Template: suggest-an-external-resource #4476

Sebster3 opened this issue Apr 12, 2023 · 4 comments · Fixed by #4674
Assignees
Labels
Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@Sebster3
Copy link
Member

Sebster3 commented Apr 12, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page and attend an onboarding session.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As developers, we need to add the labels from the Missing series so that we can avoid the GitHub bot taking off the labels when devs add them to issues.

Action Items

  • Navigate to .github/ISSUE_TEMPLATE/suggest-an-external-resource.md
  • Replace the following line
    labels: 'P-Feature: Toolkit, role: front end, size: 0.5pt'
    
    with
    label: ['P-Feature: Toolkit','role: front end','size: 0.5pt','Complexity: Missing']
    
  • Test the updated template using these instructions. Copy the contents of that comment into a new comment in this issue, and check off the boxes as you complete the steps.

For PR Reviewers and Merge Team
To review this issue, click the link below under "Link for reviewers" and verify that the labels match the updated labels string in the issue.

Link for Reviewers (to be completed by the dev during testing)
URL of the issue branch on the test Repository: [REPLACE THIS TEXT WITH URL OF THE ISSUE TEMPLATE ON THE TEST REPO]

For PM, Merge Team, or Tech Lead

  • Once the pull request associated with this issue is approved and merged, please update and edit epic Creating issues to Add Missing Labels to Issue Templates #4307 by
    • Checking off the dependency for this issue
    • If all dependencies are checked off, please move issue to the New Issue Approval column and remove the Dependency label

File and Code links you will need to work on this issue

@Sebster3 Sebster3 added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.5pt Can be done in 3 hours or less labels Apr 12, 2023
@roslynwythe roslynwythe added ready for product and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 12, 2023
@ldietz08 ldietz08 self-assigned this May 15, 2023
@github-actions
Copy link

Hi @ldietz08, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@roslynwythe
Copy link
Member

Hi @ldietz08 I added a final Action Item that describes the process for testing the updated issue template.

@roslynwythe
Copy link
Member

Hi @ldietz08 I made a change to the test instructions so please review them. I suggest that you copy the instructions into a new comment in this issue and check off the boxes as you complete the steps. Let me know if you need help and thank you for your work on this issue and your patience while we work out the test process.

@ldietz08
Copy link
Member

These issues modify the GitHub issue templates and can only be tested by pushing the code to a GitHub repository that includes the labels specified in the updated issue template. Copy the following instructions into a comment in your issue and check off the boxes to indicate your progress:

### Instructions for testing updated issue templates:
- [ ] Push your issue branch to your fork of the website repository, as described in [Section 3.1.a of CONTRIBUTING doc](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#31a-push-all-changes-to-your-issue-branch), for example:  `git push --set-upstream origin test-update-labels-1234`  
- [ ] The response from the push command will include the URL for creating a pull request.  Copy/Paste the URL below for use after testing:  
[REPLACE THIS TEXT WITH URL FOR CREATING PR]
- [ ] Browse to your fork of the website repository and click Settings 
<details><summary>Screenshot of Repository Settings</summary>

![image](https://github.com/hackforla/website/assets/5314153/8ecf2e55-2187-4ab9-acf1-2fd7548291a1)

</details> 

- [ ] Change the default branch to the new issue branch

<details><summary>Screenshot of Default Branch Setting</summary>

![image](https://github.com/hackforla/website/assets/5314153/945fe02e-035f-4215-9c25-1d46c209d8c0)

</details> 

- [ ] Further down on the settings page under Features, check the Issues checkbox

<details><summary>Screenshot of Issues Checkbox</summary>

![image](https://github.com/hackforla/website/assets/5314153/945fe02e-035f-4215-9c25-1d46c209d8c0)

</details> 

- [ ] Browse to the Issues page, then click Labels

<details><summary>Screenshot - creating labels in the test Repo</summary>

![image](https://github.com/hackforla/website/assets/5314153/208e1b07-2478-4ed3-98a1-207de58d25c5)

</details> 

- [ ] Create labels corresponding to each label that was listed in the updated issue template.  The color of the labels don't have to match those on the `hackforla/website` repository, but the text of the labels must match exactly.  
- [ ] From the Issues page, click `New Issue` then locate the template updated by your issue, and click `Get Started` to open the issue template. 
- [ ] Copy/Paste the URL of the issue template into the Resources section of the issue, replacing the text: [REPLACE THIS TEXT WITH URL OF THE ISSUE TEMPLATE ON THE TEST REPO]
 This will enable others to check the template.  
- [ ] Verify that the labels listed in the issue all appear on the issue template.  If there is a discrepancy between the labels listed in the issue and the labels that appear on the issue template, ask a dev lead or merge team member for help.  
- [ ] If the labels listed in the issue all appear on the issue template, complete the PR process by visiting the URL saved from the push command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

5 participants