Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find all the places that the "good second issue" labels is used #4423

Closed
9 of 12 tasks
Tracked by #4432 ...
jdingeman opened this issue Apr 5, 2023 · 19 comments
Closed
9 of 12 tasks
Tracked by #4432 ...

Find all the places that the "good second issue" labels is used #4423

jdingeman opened this issue Apr 5, 2023 · 19 comments
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe To Update ! No update has been provided

Comments

@jdingeman
Copy link
Member

jdingeman commented Apr 5, 2023

Overview

Find all the places that the "good second issue" labels appears so that we can change all references to point to "good first issue" labels in a future issue and when we do make the change, it changes in all our documentation and code as well.

Details

We are going to stop using good second issues and just have everyone do two good first issues

Action Items

For Merge Team/Tech Lead

Resources/Instructions

  • How to Search in VS Code
  • Hint: You can find exact phrasing in the GitHub repository search by wrapping the search term in quotation marks (")

Related issues

@jdingeman jdingeman added role: back end/devOps Tasks for back-end developers Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 1pt Can be done in 4-6 hours ready for product labels Apr 5, 2023
@jdingeman

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty changed the title Replace all "good second issue" labels with "good first issue" label Prepare to Replace all "good second issue" labels with "good first issue" label Apr 6, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the Draft Issue is still in the process of being created label Apr 6, 2023
@ExperimentsInHonesty ExperimentsInHonesty changed the title Prepare to Replace all "good second issue" labels with "good first issue" label Find all the places that the "good second issue" labels is used Apr 6, 2023
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Draft Issue is still in the process of being created ready for product labels Apr 6, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 08. Team workflow milestone Apr 6, 2023
@ExperimentsInHonesty

This comment was marked as resolved.

@github-actions
Copy link

Hi @vincentdang, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@vincentdang
Copy link
Member

vincentdang commented Apr 23, 2023

i. Availability: This upcoming week M-F weeknights.
ii. ETA: perhaps by the end of the week or the next week

@vincentdang
Copy link
Member

vincentdang commented Apr 25, 2023

@jdingeman
Okay so my strategy to searching on GitHub is to type in org:hackforla "good second issue"
or org:hackforla "good 2nd issue" in the search bar.

https://github.com/search?q=org%3Ahackforla+%22good+second+issue%22&type=Issues

The "good 2nd issue" appears manageable with 7 links.
image

The "good second issue" is bit much.

I'm able to enter in the wiki and code links but this yields 300+ issue links. I would rather avoid
rote labor if there is an easier way.

image

@vincentdang
Copy link
Member

Update: I have more or less finished searching for "good second/2nd issue" on GitHub, on the web, and on VS code so far it seems.

@vincentdang
Copy link
Member

Update: I believe I found them all or mostly all of them. I just need to relabel this and place it into the Question/In Review column.

@vincentdang vincentdang added Status: Help Wanted Internal assistance is required to make progress ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 29, 2023
@ExperimentsInHonesty
Copy link
Member

@vincentdang In the location column, the links for the items designated as Web need cleaning up or explanation.

@ExperimentsInHonesty
Copy link
Member

@hackforla/website-merge Please review this spreadsheet and identify if there are items that are not relevant that we could hide.

@vincentdang
Copy link
Member

vincentdang commented May 8, 2023

@vincentdang In the location column, the links for the items designated as Web need cleaning up or explanation.

Hi I have provided explanations in the Relevant column next to the "web" items in the spreadsheet.
As they evaluate, they could delete the explanations as they see fit.

@ExperimentsInHonesty
Copy link
Member

@vincentdang please update the sheet to make the following change

Chang the links to code, to go to the main, instead of the commit in rows 56-66

Example:
Row 56 currently says

https://github.com/hackforla/website-wiki/blob/main/docs/About-the-Website-Development-Team.md

But it used to say

https://github.com/hackforla/website-wiki/blob/24d6cd766ef1ca57c66cf458913e49796a5f8293/docs/About-the-Website-Development-Team.md

I was able to change the link by going to the url you provide and clicking on main, and then copying the url.

Add the name of the issue on rows that just have url

You added the names of the issues other places, just not on these rows.

Example:
Row 52 shows

hackforla/internship#238

and it should say

IS22 Intern Standup

with a note in the notes column saying its from the hackforla/internship repo

After you have made these changes, please reach out to the @hackforla/website-merge team to see if they have any other feedback for you.

@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed ready for dev lead Issues that tech leads or merge team members need to follow up on Status: Help Wanted Internal assistance is required to make progress labels May 16, 2023
@github-actions
Copy link

@vincentdang

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Tuesday, May 16, 2023 at 12:16 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label May 19, 2023
@vincentdang
Copy link
Member

hey i will update this tomorrow

@vincentdang
Copy link
Member

@ExperimentsInHonesty rows 61-66 do not have a main branch so I'm not sure how to deal with them. 56-60 I was able to change. for adding the name of the issues that have just the url, I'm currently trying to figure out how to get the hyperlink version of it and have not been able to figure it out just yet.

@vincentdang
Copy link
Member

Progress: rows 61-66 updated.
Blockers: 56-60 do not have a main branch. not sure what to do. not sure how to convert a url to a hyperlink for certain rows.
Availability: Weekend during the day or night.
ETA: possibly < a week.

@github-actions github-actions bot removed the To Update ! No update has been provided label May 26, 2023
@vincentdang
Copy link
Member

vincentdang commented May 28, 2023

@vincentdang please update the sheet to make the following change

Chang the links to code, to go to the main, instead of the commit in rows 56-66

Example: Row 56 currently says

https://github.com/hackforla/website-wiki/blob/main/docs/About-the-Website-Development-Team.md

But it used to say

https://github.com/hackforla/website-wiki/blob/24d6cd766ef1ca57c66cf458913e49796a5f8293/docs/About-the-Website-Development-Team.md

I was able to change the link by going to the url you provide and clicking on main, and then copying the url.

Add the name of the issue on rows that just have url

You added the names of the issues other places, just not on these rows.

Example: Row 52 shows

hackforla/internship#238

and it should say

IS22 Intern Standup

with a note in the notes column saying its from the hackforla/internship repo

After you have made these changes, please reach out to the @hackforla/website-merge team to see if they have any other feedback for you.



Update: I have finished the edits on the spreadsheet that Bonnie has requested that I do.
I am now reaching out to the merge team for feedback.
@hackforla/website-merge
@ExperimentsInHonesty
@jdingeman

@github-actions github-actions bot added the To Update ! No update has been provided label Jun 23, 2023
@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jun 27, 2023
@roslynwythe
Copy link
Member

Hi @vincentdang it looks like Bonnie was asking for URLs such as found in row 52 column A, to contain link text with the name of the issue. Is that a correct interpretation? If so, would that be possible?

@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jul 31, 2023
@vincentdang
Copy link
Member

Hi @vincentdang it looks like Bonnie was asking for URLs such as found in row 52 column A, to contain link text with the name of the issue. Is that a correct interpretation? If so, would that be possible?

hi I think get what you mean. it's been a while for this issue but let me see if i can get it to look that way.

@ExperimentsInHonesty
Copy link
Member

I am marking this spreadsheet and issue as complete. Thank you @vincentdang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe To Update ! No update has been provided
Projects
Development

No branches or pull requests

4 participants