Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

img Tag Refactor: Toolkit page #4366

Closed
3 tasks done
Tracked by #5040
JessicaLucindaCheng opened this issue Apr 2, 2023 · 4 comments · Fixed by #4374
Closed
3 tasks done
Tracked by #5040

img Tag Refactor: Toolkit page #4366

JessicaLucindaCheng opened this issue Apr 2, 2023 · 4 comments · Fixed by #4374
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Apr 2, 2023

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

We want to change an img HTML tag ending with a slash (<img.../>) to an img tag without an ending slash (<img...>) so that the codebase is consistent with how we use img HTML tags.

Action Items

  • In your local IDE, navigate to pages/toolkit.html
  • Remove the ending slash in the img HTML tag by changing
<img class="header-hero-image" src="/assets/images/toolkit/toolkit-hero.svg" alt="" />

to

<img class="header-hero-image" src="/assets/images/toolkit/toolkit-hero.svg" alt="">
  • Using Docker, check the page remains the same in mobile, tablet, and desktop views as on the current website (See 2 in the Resources/Instructions section below)

Resources/Instructions

  1. pages/toolkit.html
  2. Toolkit page: https://www.hackforla.org/toolkit
  3. This issue is tracked in HfLA-Website: img Tag Audit spreadsheet's img with Ending Slash tab, which is part of Rollout Plan: Refactor code with img HTML tags to end without a slash #4362
@JessicaLucindaCheng JessicaLucindaCheng added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.5pt Can be done in 3 hours or less labels Apr 2, 2023
@github-actions github-actions bot added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Apr 2, 2023
@github-actions

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added P-Feature: Toolkit https://www.hackforla.org/toolkit/ and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. labels Apr 2, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

Hi @cng008, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@cng008
Copy link
Member

cng008 commented Apr 2, 2023

Availability for this week: after 2pm PT
My estimated ETA for completing this issue: 4/3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
Development

Successfully merging a pull request may close this issue.

3 participants