Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SDG background color classes: 2-5, 8-11, 13, 16, 17 #4344

Closed
5 tasks done
Tracked by #4153 ...
JessicaLucindaCheng opened this issue Mar 30, 2023 · 13 comments · Fixed by #4698
Closed
5 tasks done
Tracked by #4153 ...

Add SDG background color classes: 2-5, 8-11, 13, 16, 17 #4344

JessicaLucindaCheng opened this issue Mar 30, 2023 · 13 comments · Fixed by #4698
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Milestone

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 30, 2023

Dependency

Overview

We need to add background color classes using the SDG (Sustainable Development Goal) color variables to our repo so we can use these classes with their corresponding, matching SDG icons.

Action Items

  • In the _sass/elements, create a new file: _background-sdg-colors.scss
  • In the file you just created, add the following:
/**
 * Sustainable Development Goal (SDG) Background Colors
 *
 * These background color classes match the colors of the SDG icons provided by the United Nations (UN):
 * https://www.un.org/sustainabledevelopment/news/communications-material/
 */

.background-color-sdg2 { background-color: $color-sdg2; }
.background-color-sdg3 { background-color: $color-sdg3; }
.background-color-sdg4 { background-color: $color-sdg4; }
.background-color-sdg5 { background-color: $color-sdg5; }
.background-color-sdg8 { background-color: $color-sdg8; }
.background-color-sdg9 { background-color: $color-sdg9; }
.background-color-sdg10 { background-color: $color-sdg10; }
.background-color-sdg11 { background-color: $color-sdg11; }
.background-color-sdg13 { background-color: $color-sdg13; }
.background-color-sdg16 { background-color: $color-sdg16; }
.background-color-sdg17 { background-color: $color-sdg17; }
  • In the _sass/main.scss, under the Elements section, add this:
@import 'elements/background-sdg-colors';

Merge Team, Technical Lead, or Product Manager

  • Once the pull request associated with this issue is merged, go to each of the following issues and check if all the issues/dependencies listed under the Dependency section are closed or checked off. If the dependencies are all closed or checked, move those issues into the New Issue Approval column, remove the Dependency label on it, and add a ready for dev lead label to it.

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers Complexity: Small Take this type of issues after the successful merge of your second good first issue Draft Issue is still in the process of being created size: 0.25pt Can be done in 0.5 to 1.5 hours p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) labels Mar 30, 2023
@JessicaLucindaCheng JessicaLucindaCheng self-assigned this Mar 30, 2023
@github-actions

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng added the Dependency An issue is blocking the completion or starting of another issue label Mar 30, 2023
@JessicaLucindaCheng

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng removed their assignment Mar 30, 2023
@JessicaLucindaCheng JessicaLucindaCheng removed the Draft Issue is still in the process of being created label Mar 30, 2023
@jdingeman jdingeman added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed Dependency An issue is blocking the completion or starting of another issue labels Apr 4, 2023
@JessicaLucindaCheng JessicaLucindaCheng added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on labels Apr 5, 2023
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Apr 6, 2023
@qngyn qngyn self-assigned this Apr 8, 2023
@qngyn

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@wKategianes wKategianes self-assigned this Apr 17, 2023
@wKategianes

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@jdingeman
Copy link
Member

Hi @wKategianes - when you take on an issue, please remember to move the issue into the In Progress column. Thanks!

@github-actions github-actions bot added the To Update ! No update has been provided label Apr 28, 2023
@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed To Update ! No update has been provided labels May 5, 2023
@roslynwythe

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels May 15, 2023
@jenny-alexander jenny-alexander self-assigned this May 19, 2023
@github-actions
Copy link

Hi @jenny-alexander, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@jenny-alexander
Copy link
Member

Availability: Friday May 19 10-12pm.
ETA: Friday May 19 10-12pm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue p-feature: SDGs SDGs wherever they appear on the site (they all use a color library, set of icons, etc.) role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
7 participants