Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design System: Recommendations for Page Card CSS/HTML Standard #4296

Open
3 of 8 tasks
Tracked by #2226
jdingeman opened this issue Mar 27, 2023 · 26 comments
Open
3 of 8 tasks
Tracked by #2226

Design System: Recommendations for Page Card CSS/HTML Standard #4296

jdingeman opened this issue Mar 27, 2023 · 26 comments
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: Accessibility Issues that would broaden website accessibility Feature: Design system manual dependency release role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours

Comments

@jdingeman
Copy link
Member

jdingeman commented Mar 27, 2023

Dependency

Overview

We need to document recommendations for the .page-card classes so that we can then standardize and implement them for the HfLA Website.

Action Items

  • In issue Design System: Audit Page Card CSS/HTML standard #2061, devs created a new spreadsheet noting all instances of a .*-card class and created a write-up with research on accessibility and standard practices. As the developer assigned to this issue, you will:
  • Go through all of the instances in the spreadsheet of the .*-card classes in the HfLA repo
    • Review each instance to see how it was coded, and compare it against the standards written in the write-up.
    • Write any "relevant methods" pertaining to accessibility and industry standard (i.e. do they use empty alt texts, are they WCAG 2.1 compliant, can they be tab-focused, etc.)
    • If a class implements something that is "off" or otherwise non-standard and can be standardized, write specific recommendations on what we can do to make the class more compliant, accessible, etc.
  • For each instance, write the in the "Impact" column what the ramifications are for changing/refactoring any instance of the .*page-card if it needs to be changed.

Merge Team

Resources/Instructions

/* Current default for page-card*/
.page-card {
    border-radius: 20px;
    overflow: hidden;
    width: 100%;
  }
@github-actions

This comment was marked as outdated.

@KazushiR

This comment was marked as outdated.

@github-actions github-actions bot added the To Update ! No update has been provided label Apr 21, 2023
@KazushiR KazushiR removed the To Update ! No update has been provided label Apr 24, 2023
@KazushiR

This comment was marked as outdated.

@KazushiR

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@KazushiR

This comment was marked as outdated.

@KazushiR

This comment was marked as outdated.

@github-actions github-actions bot added the To Update ! No update has been provided label May 5, 2023
@KazushiR KazushiR removed the To Update ! No update has been provided label May 5, 2023
@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label May 12, 2023
@github-actions

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@KazushiR

This comment was marked as outdated.

@KazushiR KazushiR removed their assignment May 15, 2023
@ExperimentsInHonesty ExperimentsInHonesty added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels May 23, 2023
@ExperimentsInHonesty

This comment was marked as outdated.

@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 18, 2023
@romainyvernes romainyvernes self-assigned this Oct 22, 2023
@github-actions

This comment was marked as outdated.

@romainyvernes romainyvernes removed their assignment Oct 28, 2023
@KyleA99 KyleA99 self-assigned this Nov 2, 2023

This comment was marked as outdated.

@KyleA99

This comment was marked as outdated.

@KyleA99

This comment was marked as outdated.

@KyleA99

This comment was marked as outdated.

@KyleA99

This comment was marked as outdated.

@github-actions github-actions bot added the To Update ! No update has been provided label Dec 1, 2023

This comment was marked as outdated.

@KyleA99 KyleA99 removed their assignment Dec 2, 2023
@KyleA99

This comment was marked as outdated.

@freaky4wrld freaky4wrld self-assigned this Dec 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

Hi @freaky4wrld, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: Thursday 12/14

@freaky4wrld
Copy link
Member

Issue is still in progress. might take sometime due to slow pace work.
Availability: Evenings
ETA: EOD Thursday 12/18

@freaky4wrld
Copy link
Member

@jdingeman I'm just confused can you tell me about, to which version of code I've to write the recommendations, the spreadsheet consist of a Permalink that doesn't match with the current version of code in gh-pages. So can you please clear on that. Thanks for the help

@t-will-gillis t-will-gillis removed the To Update ! No update has been provided label Dec 18, 2023
@t-will-gillis
Copy link
Member

Hey @freaky4wrld FYI I don't believe Justin has been logging in recently so you might not get a response.

If I understand your question: I would ignore the Permalink and review using the current code on gh-pages.

@freaky4wrld
Copy link
Member

Waiting for @roslynwythe suggestions for the issue that are going to be addressed on the onboarding meeting at 8th this month

@roslynwythe
Copy link
Member

@freaky4wrld I moved this issue into "New Issue Approval" because I realized that the spreadsheet is out of date (for instance, it does not include toolkit and guides pages) and I need to consult with PM about how to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Dependency An issue is blocking the completion or starting of another issue Feature: Accessibility Issues that would broaden website accessibility Feature: Design system manual dependency release role: front end Tasks for front end developers size: 3pt Can be done in 13-18 hours
Projects
Development

No branches or pull requests

8 participants