Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate Reusable Functions in github-actions #3750

Closed
5 tasks done
jdingeman opened this issue Nov 28, 2022 · 33 comments · Fixed by #5944
Closed
5 tasks done

Consolidate Reusable Functions in github-actions #3750

jdingeman opened this issue Nov 28, 2022 · 33 comments · Fixed by #5944
Assignees
Labels
Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@jdingeman
Copy link
Member

jdingeman commented Nov 28, 2022

Overview

Developers have noted that certain javascript functions in github-actions are being declared and defined across multiple files. We want to make these functions reusable within the codebase so they are not being defined multiple times for the same function across different files.

Action Items

  • Look through the github-actions folder and find all instances of a function that is defined more than once
    • e.g. getTimeline(issueNum) is defined in add-label.js and preliminary-update-comment.js
    • Take note of any functions that have the same name, but different sets of parameters
  • Define all reusable functions within the github-actions/utils folder so they can be called in other files without redefining them
  • Test in your local repo that this does not break any existing GHAs

Resources/Instructions

@jdingeman jdingeman added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms ready for dev lead Issues that tech leads or merge team members need to follow up on size: 1pt Can be done in 4-6 hours Draft Issue is still in the process of being created labels Nov 28, 2022
@jdingeman jdingeman added Ready for Prioritization and removed ready for dev lead Issues that tech leads or merge team members need to follow up on Draft Issue is still in the process of being created labels Jan 21, 2023
@ExperimentsInHonesty ExperimentsInHonesty added size: 2pt Can be done in 7-12 hours and removed Ready for Prioritization size: 1pt Can be done in 4-6 hours labels Jan 30, 2023
@wendybarrios wendybarrios self-assigned this Mar 12, 2023
@github-actions

This comment was marked as outdated.

@wendybarrios

This comment was marked as outdated.

@ExperimentsInHonesty

This comment was marked as outdated.

@github-actions github-actions bot added the To Update ! No update has been provided label Mar 24, 2023
@github-actions

This comment was marked as outdated.

@wendybarrios

This comment was marked as outdated.

@wendybarrios wendybarrios added Status: Updated No blockers and update is ready for review and removed To Update ! No update has been provided labels Mar 26, 2023
@github-actions github-actions bot added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Mar 31, 2023
@wendybarrios

This comment was marked as outdated.

@jdingeman

This comment was marked as outdated.

@wendybarrios

This comment was marked as outdated.

@github-actions github-actions bot removed the To Update ! No update has been provided label Apr 14, 2023
@one2code

This comment was marked as resolved.

@github-actions github-actions bot added the To Update ! No update has been provided label Sep 8, 2023
@github-actions

This comment was marked as resolved.

@one2code

This comment was marked as resolved.

@github-actions github-actions bot removed the To Update ! No update has been provided label Sep 15, 2023
@github-actions github-actions bot added the To Update ! No update has been provided label Sep 22, 2023
@github-actions

This comment was marked as resolved.

@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed To Update ! No update has been provided labels Sep 29, 2023
@github-actions

This comment was marked as resolved.

@LRenDO

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@github-actions

This comment was marked as resolved.

@LRenDO

This comment was marked as resolved.

@LRenDO LRenDO added Ready for Prioritization and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Nov 1, 2023
@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed Ready for Prioritization labels Nov 6, 2023
@aadilahmed aadilahmed self-assigned this Nov 27, 2023
Copy link

Hi @aadilahmed, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@aadilahmed
Copy link
Member

Availability: 9am- 5pm Monday-Friday
ETA: 11/28 EOD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging a pull request may close this issue.

8 participants