Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused alt-hero field from vrms.md project file #3214

Closed
4 tasks done
Tracked by #2722
JessicaLucindaCheng opened this issue Jun 3, 2022 · 2 comments · Fixed by #3226
Closed
4 tasks done
Tracked by #2722

Remove unused alt-hero field from vrms.md project file #3214

JessicaLucindaCheng opened this issue Jun 3, 2022 · 2 comments · Fixed by #3226
Assignees
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jun 3, 2022

Overview

As a developer, I want to make sure unused code is removed from the codebase in project cards so that

  • time to load the website is as low as possible,
  • it's easier to understand the code, and
  • time to review the code is reduced.

Details

In project md files, image-hero is a decorative background image and alt-hero is the alt text associated with image-hero. However, alt-hero text is not used anywhere in our codebase since the image-hero is used as an SCSS background image.

Moreover, if the image-hero were to be used in an img HTML tag in the future, the alt text for all the image-hero images would be alt="", which could be set programmatically for all the alt properties associated with each image-hero.

Action Items

  • For the file _projects/vrms.md, remove line 8 for the alt-hero
alt-hero: 'City of LA skyline at dusk.'

Resources/Instructions

File and code links you will need to work on this issue

  • Directory to find the page once you have it in your IDE: _projects/vrms.md
  • Click on the link below to see the source file code:
    alt-hero: 'City of LA skyline at dusk.'

Information about WCAG

@JessicaLucindaCheng JessicaLucindaCheng added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) Size: Good second issue size: 0.5pt Can be done in 3 hours or less labels Jun 3, 2022
@github-actions

This comment was marked as resolved.

@DonaldBrower
Copy link
Member

Availability for this week:
6 Hours (This evening, Tuesday and Wednesday evenings)

My estimated ETA for completing this issue:
Tonight, before 12a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants