Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix variable name in citizen-engagement.js #2887

Closed
4 tasks done
tamara-snyder opened this issue Feb 25, 2022 · 3 comments · Fixed by #2981
Closed
4 tasks done

Fix variable name in citizen-engagement.js #2887

tamara-snyder opened this issue Feb 25, 2022 · 3 comments · Fixed by #2981
Assignees
Labels
Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages good first issue Good for newcomers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@tamara-snyder
Copy link
Member

tamara-snyder commented Feb 25, 2022

Dependency

Overview

We need to fix a typo in a variable name so that we can reuse it reliably.

Details

As developers, it is important to write our JavaScript variable names carefully so that we don't mistakenly declare new variables that pollute the global namespace. In this issue, we will fix a variable name typo in assets/js/citizen-engagement.js in order to prevent a global variable from being declared later in the file.

Action Items

  • In line 4 of assets/js/citizen-engagement.js, change let currentDropown; to let currentDropdown;
  • Check that the Citizen Engagement page still functions as expected
  • Create a pull request for this issue according to the instructions found in the pull request section of CONTRIBUTING.md

Resources/Instructions

@tamara-snyder tamara-snyder added role: front end Tasks for front end developers Size: Good second issue Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages labels Feb 25, 2022
@github-actions

This comment was marked as outdated.

@tamara-snyder tamara-snyder added the Dependency An issue is blocking the completion or starting of another issue label Feb 25, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

@tamara-snyder

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages good first issue Good for newcomers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

4 participants