Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from check.yml credits file #2806

Closed
2 of 5 tasks
Tracked by #2775
riddle015 opened this issue Feb 20, 2022 · 9 comments · Fixed by #3961
Closed
2 of 5 tasks
Tracked by #2775

Edit content field and remove type field from check.yml credits file #2806

riddle015 opened this issue Feb 20, 2022 · 9 comments · Fixed by #3961
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@riddle015
Copy link
Member

riddle015 commented Feb 20, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/check.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

@riddle015 riddle015 added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Feb 20, 2022
@github-actions

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit content field and remove type field from check.yml file Edit content field and remove type field from check.yml credits file Feb 24, 2022
@JessicaLucindaCheng JessicaLucindaCheng added this to the y. Technical debt milestone Mar 9, 2022
@JessicaLucindaCheng

This comment was marked as outdated.

@AsherEngelberg AsherEngelberg self-assigned this Jun 21, 2022
@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jun 24, 2022
@github-actions

This comment was marked as resolved.

@AsherEngelberg

This comment was marked as outdated.

@AsherEngelberg AsherEngelberg removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jun 24, 2022
@github-actions github-actions bot added Status: Updated No blockers and update is ready for review 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed Status: Updated No blockers and update is ready for review labels Jul 1, 2022
@github-actions

This comment was marked as outdated.

@github-actions

This comment was marked as outdated.

@bishrfaisal

This comment was marked as outdated.

@bishrfaisal bishrfaisal added ready for dev lead Issues that tech leads or merge team members need to follow up on and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Sep 28, 2022
@blulady blulady removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Oct 26, 2022
@JessicaLucindaCheng

This comment was marked as resolved.

@Thinking-Panda Thinking-Panda self-assigned this Feb 10, 2023
@github-actions
Copy link

Hi @Thinking-Panda, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

7 participants