Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from calendar-time.yml credits file #2800

Closed
2 of 5 tasks
Tracked by #2775
JessicaLucindaCheng opened this issue Feb 19, 2022 · 5 comments · Fixed by #3258
Closed
2 of 5 tasks
Tracked by #2775
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Help Wanted Internal assistance is required to make progress Status: Updated No blockers and update is ready for review

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Feb 19, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/calendar-time.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

@JessicaLucindaCheng JessicaLucindaCheng added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Feb 19, 2022
@github-actions

This comment was marked as outdated.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit content field and remove type field from calendar-time.yml file Edit content field and remove type field from calendar-time.yml credits file Feb 19, 2022
@Providence-o Providence-o added this to the z. Excellent level milestone Feb 19, 2022
@oliviaywangn oliviaywangn self-assigned this Jun 1, 2022
@oliviaywangn
Copy link
Member

oliviaywangn commented Jun 1, 2022

Availability: 5 hours
ETA: 2 weeks

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Jun 3, 2022
@github-actions github-actions bot removed the Status: Updated No blockers and update is ready for review label Jun 10, 2022
@github-actions
Copy link

@oliviaywangn

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, June 7, 2022 at 12:21 AM PST.

@github-actions github-actions bot added the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jun 10, 2022
@oliviaywangn
Copy link
Member

Progress: Have edited the yml file, but I am not sure how to upload it. Will join Sunday meeting for help.
Availability: 4 hours
ETA: 1 week

@oliviaywangn oliviaywangn added the Status: Help Wanted Internal assistance is required to make progress label Jun 12, 2022
@oliviaywangn
Copy link
Member

Progress: have pushed the changes to git hub and submitted a PR
Availability: 1 hour

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Help Wanted Internal assistance is required to make progress Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

3 participants