Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from button.yml credits file #2799

Closed
5 tasks done
Tracked by #2775
JessicaLucindaCheng opened this issue Feb 19, 2022 · 2 comments · Fixed by #3182
Closed
5 tasks done
Tracked by #2775

Edit content field and remove type field from button.yml credits file #2799

JessicaLucindaCheng opened this issue Feb 19, 2022 · 2 comments · Fixed by #3182
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Feb 19, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/button.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

@JessicaLucindaCheng JessicaLucindaCheng added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Credit https://www.hackforla.org/credits/ size: 0.5pt Can be done in 3 hours or less labels Feb 19, 2022
@github-actions

This comment was marked as resolved.

@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit content field and remove type field from button.yml file Edit content field and remove type field from button.yml credits file Feb 19, 2022
@Providence-o Providence-o added this to the z. Excellent level milestone Feb 19, 2022
@usaboo usaboo assigned usaboo and unassigned usaboo Feb 20, 2022
@alan-zambrano alan-zambrano self-assigned this May 30, 2022
@alan-zambrano
Copy link
Member

Availability for this week: 3 hrs
My estimated ETA for completing this issue: Finished

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

4 participants