Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-existent classes from citizen-engagement.html #2721

Closed
2 tasks done
JessicaLucindaCheng opened this issue Jan 27, 2022 · 5 comments · Fixed by #2879
Closed
2 tasks done

Remove non-existent classes from citizen-engagement.html #2721

JessicaLucindaCheng opened this issue Jan 27, 2022 · 5 comments · Fixed by #2879
Assignees
Labels
good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours

Comments

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Jan 27, 2022

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

As developers, we should make sure our code does not use SCSS classes that do not exist. For this issue, we will remove the non-existent classes card-body and card-width from a line of code.

Action Items

            <div class="page-card card-primary page-card-lg card-body card-width organizations">

so the result is

            <div class="page-card card-primary page-card-lg organizations">
  • Using Docker locally on your computer, check Citizen Engagement page looks the same as the page on the current site in various desktop, tablet, and mobile views using developer tools

Resources/Instructions

@JessicaLucindaCheng JessicaLucindaCheng added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement size: 1pt Can be done in 4-6 hours labels Jan 27, 2022
@github-actions

This comment has been minimized.

@mayanknoldus
Copy link

I would like to work on this issue. Could you please assign me this.

@JessicaLucindaCheng
Copy link
Member Author

JessicaLucindaCheng commented Jan 27, 2022

@mayanknoldus Thanks for your interest in working on this issue. However, this issue is not ready to be worked on. Also, to work on any of our issues, you need to join Hack for LA. (There are no fees for joining.) If you are interested in joining, please follow the steps on our Getting Started page.

@JessicaLucindaCheng JessicaLucindaCheng changed the title DRAFT: Remove non-existent classes from citizen-engagement.html Remove non-existent classes from citizen-engagement.html Jan 27, 2022
@A-BMT02 A-BMT02 self-assigned this Feb 23, 2022
@JessicaLucindaCheng
Copy link
Member Author

@A-BMT02
At the time you self-assign an issue, make sure to write in a comment the following:

  • Availability: (how many hours you have to work on the issue this week)
  • ETA: (when you think you will finish the issue)

@A-BMT02
Copy link
Member

A-BMT02 commented Feb 24, 2022

Noted , i will next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Citizen Engagement https://www.hackforla.org/citizen-engagement role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 1pt Can be done in 4-6 hours
Projects
Development

Successfully merging a pull request may close this issue.

5 participants