Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit content field and remove type field from 404.yml credits file #2633

Closed
6 tasks done
Tracked by #2775
SAUMILDHANKAR opened this issue Dec 27, 2021 · 2 comments · Fixed by #3158
Closed
6 tasks done
Tracked by #2775

Edit content field and remove type field from 404.yml credits file #2633

SAUMILDHANKAR opened this issue Dec 27, 2021 · 2 comments · Fixed by #3158
Assignees
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less

Comments

@SAUMILDHANKAR
Copy link
Member

SAUMILDHANKAR commented Dec 27, 2021

Dependency

Prerequisite

  1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
  2. Please make sure you have read our Hack for LA Contributing Guide before you claim/start working on an issue.

Overview

As a developer, I want to edit the content field and remove the type field from a credit's yml file so that redundant code is removed and the code is easier to understand.

Details

Currently, in each credit's yml file, there is a content field and a type field, which contains similar information. Since the fields are redundant, we decided to remove the type field.

Also, we changed the content field to the content-type field to make it clearer what its purpose is. The possible values for content-type field are image, video, or audio; other types of content can be added if necessary. In the future, this will allow developers a way to differentiate easily between different types of content in order to show each credit's media file correctly on the website.

Action Items

For the file _data/internal/credits/404.yml, do the following:

Resources/Instructions

File and Code links you will need to work on this issue

Availability for this week: 6 hrs
My estimated ETA for completing this issue: 10 minutes

@SAUMILDHANKAR SAUMILDHANKAR added good first issue Good for newcomers role: front end Tasks for front end developers P-Feature: Credit https://www.hackforla.org/credits/ labels Dec 27, 2021
@github-actions

This comment was marked as outdated.

@SAUMILDHANKAR SAUMILDHANKAR added the Dependency An issue is blocking the completion or starting of another issue label Dec 30, 2021
@pattshreds pattshreds assigned pattshreds and unassigned pattshreds Jan 17, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title Remove Content and type texts from 404.yml file Edit content and remove type texts from 404.yml file Feb 5, 2022
@JessicaLucindaCheng JessicaLucindaCheng removed the Dependency An issue is blocking the completion or starting of another issue label Feb 13, 2022
@SAUMILDHANKAR SAUMILDHANKAR changed the title Edit content and remove type texts from 404.yml file Edit content field and remove type field from 404.yml file Feb 13, 2022
@JessicaLucindaCheng JessicaLucindaCheng changed the title Edit content field and remove type field from 404.yml file Edit content field and remove type field from 404.yml credits file Feb 19, 2022
@ExperimentsInHonesty ExperimentsInHonesty added this to the y. Technical debt milestone Mar 5, 2022
@scorbz9 scorbz9 self-assigned this May 18, 2022
@scorbz9
Copy link
Member

scorbz9 commented May 18, 2022

How many hours did it take you to finish the pre-work up to and including adding your initial ETA and availability for your good first issue, including attending your first meetings?
Answer: ~4.5 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Credit https://www.hackforla.org/credits/ role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
Development

Successfully merging a pull request may close this issue.

5 participants