Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the alt text for program-area page images and ensure that they adhere to WCAG #2354

Closed
2 of 3 tasks
macho-catt opened this issue Oct 10, 2021 · 14 comments
Closed
2 of 3 tasks
Assignees
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Accessibility Issues that would broaden website accessibility role: design size: missing Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Oct 10, 2021

Overview

We need to ensure that alt text for images adhere to Web Content Accessibility Guidelines (WCAG). For this issue, we will tackle the images under the program area page.

Details

Developers identified that some alt texts in the program areas page should be reviewed because they are either inaccurate or too long. Ideally, alt text should be descriptive but short and succinct. According to the WCAG page, an accompanying alt text should be short. Additionally, the Functional Accessibility Evaluator (FAE) recommends for alt text to be no more than 100 characters.

Action Items

UI/UX Design

  • Refer to this google doc for an itemized list of each alt text for each images under program area
  • For each item in the list, identify if the alt text needs to be changed or not.

Development

  • Create issues for that particular alt text should be created (preferably labelled good first issue) for new developers to fix

Resources/Instructions

Program Area Page
WCAG section on alt text
FAE rule 4: alt text should be less than 100 characters
Google sheet list

@github-actions
Copy link

Hi @macho-catt.

Good job adding the required labels to this issue.

Additional Resources:
Wiki: How to add status labels to issues (WIP. Link will be updated when the wiki is done)
Wiki: How to create issues (WIP. Link will be updated when the wiki is done)

@ExperimentsInHonesty ExperimentsInHonesty added this to the z. Accessibility milestone Oct 10, 2021
@kristine-eudey kristine-eudey added good first issue Good for newcomers Complexity: Small Take this type of issues after the successful merge of your second good first issue and removed Complexity: Medium good first issue Good for newcomers labels Oct 28, 2021
@jenjen26 jenjen26 self-assigned this Nov 9, 2021
@jenjen26
Copy link
Member

jenjen26 commented Nov 9, 2021

Progress: completed 11/19
Blockers: none.
Availability:
ETA: moved to UAT

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Nov 12, 2021
@jenjen26
Copy link
Member

To Discuss for 11/14/21 meeting: Do we think these images provide meaningful information or are they decorative?
Program Area Page

Decorative:

  • supplementary to link text to improve its appearance or increase clickable area
  • illustrative of adjacent text but not contributing information ("eye-candy"); for formatting
  • identified and described by surrounding text (in this case the links to each project act as the surrounding text which would be identified by screen readers)

If images provide more meaning = needs alt text
If images are decorative = null alt text (alt="")

Alt text decision Tree
Decorative Images and alt text

@kristine-eudey @macho-catt

@kristine-eudey
Copy link
Member

Hi @jenjen26, we discussed this at the Sunday meeting 10/14. I shared your findings with Bonnie and the team, she would like to review the articles you shared and we will revisit at the 11/17 meeting with UX and Product leads. Since your suggestion is something we could potentially apply site-wide to improve accessibility, a bit more consideration is needed. Will update here after that meeting and let you know how best to proceed. Thanks so much for your work on this!

@ExperimentsInHonesty
Copy link
Member

I have not read the articles proceed on your collective judgement and please annotate in the wiki what the decision is, along with the links to the articles, in case other team members want to revisit this in the future

@jenjen26
Copy link
Member

The team judgment at 11/18 design meeting was for the images to be considered decorative, therefore null alt text. I have updated the google document to reflect these changes.

@JessicaLucindaCheng

This comment was marked as outdated.

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Oct 12, 2022

Not ready for dev lead. Need another going over, adding the images that are missing from the spreadsheet and if a change is needed.

When it is ready, make sure you add this text All the issues are going to be good first or good second and only involve having empty alt text. (i.e., all of the images on the page are decorative).

@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed Status: Updated No blockers and update is ready for review labels Oct 14, 2022
@github-actions

This comment was marked as outdated.

@7kram 7kram added Status: Updated No blockers and update is ready for review and removed 2 weeks inactive An issue that has not been updated by an assignee for two weeks labels Oct 16, 2022
@7kram
Copy link
Member

7kram commented Oct 16, 2022

Page has been QAed and is ready for dev lead to make issues to change alt text out of it

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented Jan 24, 2023

On this page https://github.com/hackforla/website/blob/gh-pages/pages/program-areas.html we need to replace all the alts with alt=""

- 24            <img class="page-card-image" src="{{ program_areas[1].image }}" alt="{{ program_areas[1].image_alt }}" />
- 47             <img class="project-card-mini-image" src="{{project.image}}" alt="{{project.image_alt}}" />
- 72 & 79     alt="join us card image"

@MattPereira MattPereira self-assigned this Jan 26, 2023
@github-actions

This comment was marked as outdated.

@MattPereira
Copy link
Contributor

MattPereira commented Jan 26, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Accessibility Issues that would broaden website accessibility role: design size: missing Status: Updated No blockers and update is ready for review
Projects
Development

No branches or pull requests

10 participants