Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Research and Provide a Demo of Unit Test Implementation for HfLA Repo #2249

Closed
2 of 8 tasks
abuna1985 opened this issue Sep 11, 2021 · 47 comments
Closed
2 of 8 tasks
Labels
Complexity: Large Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours

Comments

@abuna1985
Copy link
Member

abuna1985 commented Sep 11, 2021

Overview

We need to see if it is feasible to implement unit tests for JavaScript functionality within the Hack for LA website repo, both within GitHub Action files and within client-side JavaScript. Ideally the same test framework would be used for unit testing both the back end and front end JavaScript.

Action Items

  • Research implementation of unit tests in a Jekyll environment, with the goal of finding a test framework that could be used for automated testing of both the back end (GitHub Actions) and front end (client-side) JavaScript in the HfLA website repo. For the purpose of this issue, the test can be executed manually from the command-line, but it must be possible to incorporate into an automation in a future issue
    • Suggestions: Mocha, Jasmine
  • Create a new branch and implement a library that provides unit testing
    • Add unit test for 1 JavaScript file within the HfLA website repo
    • Add unit test for 1 Github action file
  • Create Draft Pull request with the unit test implementation for the dev team to review
  • Demo the unit test implementation for the back-end meeting on Thursday
  • Determine with the rest of the dev team whether adding unit tests is feasible after the demo

Resources/Instructions

https://mochajs.org/
https://jasmine.github.io/
Karma test runner

@abuna1985 abuna1985 added role: back end/devOps Tasks for back-end developers Complexity: Medium Feature: Infrastructure For changes on site technical architecture labels Sep 11, 2021
@github-actions

This comment has been minimized.

@abuna1985 abuna1985 changed the title Research and Provide a Demo of Unit Test implementation for HfLA repo Research and Provide a Demo of Unit Test Implementation for HfLA Repo Sep 11, 2021
@SAUMILDHANKAR SAUMILDHANKAR added the size: 2pt Can be done in 7-12 hours label Jun 18, 2022
@arpitapandya arpitapandya self-assigned this Sep 2, 2022
@github-actions

This comment has been minimized.

@arpitapandya

This comment was marked as outdated.

@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Sep 9, 2022
@arpitapandya

This comment was marked as outdated.

@arpitapandya arpitapandya removed their assignment Sep 16, 2022
@arpitapandya

This comment was marked as outdated.

@ExperimentsInHonesty ExperimentsInHonesty added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Mar 24, 2023
@ExperimentsInHonesty

This comment was marked as resolved.

@ExperimentsInHonesty ExperimentsInHonesty removed Status: Updated No blockers and update is ready for review ready for dev lead Issues that tech leads or merge team members need to follow up on labels Mar 24, 2023
@nnr-nnr nnr-nnr self-assigned this Mar 26, 2023
@github-actions

This comment has been minimized.

@nnr-nnr
Copy link
Member

nnr-nnr commented Mar 26, 2023

Availability: 3–8 PM M–F
ETA: 9 PM Thurs. 3/30/23

@nnr-nnr
Copy link
Member

nnr-nnr commented Mar 31, 2023

Progress Update

  • There's seems to be limited info on testing in a Jekyll environment, so I think i'm going to stick with the linked resource.
  • I got some questions answered at OHs about the logistics, ie that there is no backend team meeting and I could just present at a normal dev meeting. Also, that the "Draft Pull request" can just be treated as a PR that won't be merged.
  • No blockers.
  • Will work through the checklist this weekend.

@nnr-nnr
Copy link
Member

nnr-nnr commented Apr 7, 2023

Research implementation of unit tests in a Jekyll environment. Provide the results of the research in a comment within this issue.

There are limited information and resources on the web about unit testing in a Jekyll environment. Besides the library attached in this Issue (Joule, last updated 2017), I found suggestions of using GitHub actions to test code before pushing. Others suggest using the following together for a complete acceptance testing framework for Jekyll sites:

  • RSpec — Behavior Driven Development for Ruby
  • Capybara — Testing of web applications via simulation of a real user’s interaction with your app
  • Selenium — Browser automation

@nnr-nnr
Copy link
Member

nnr-nnr commented Apr 7, 2023

BLOCKER:
I cannot do unit testing with Joule because I do not have permissions to install Joule in the repo. Running this command in terminal:
gem install jekyll-joule
resulted in this error message:

Fetching addressable-2.8.3.gem
Fetching sass-embedded-1.61.0-x86_64-darwin.gem
ERROR:  While executing gem ... (Gem::FilePermissionError)
    You don't have write permissions for the /Library/Ruby/Gems/2.6.0 directory.

@nnr-nnr nnr-nnr added Blockers Status: Help Wanted Internal assistance is required to make progress and removed Blockers labels Apr 7, 2023
@github-actions github-actions bot added 2 weeks inactive An issue that has not been updated by an assignee for two weeks and removed To Update ! No update has been provided labels May 31, 2024

This comment has been minimized.

@Dartis4
Copy link
Member

Dartis4 commented Jun 1, 2024

Progress: Found a few leads for testing frameworks. Need to try implementing into the work flow to see ig things are viable. In talks with Roslyn and Will about viability of the libraries as well.
Blockers: None at the moment.
Availability: I should be available between 10am - 5pm each day this week.
ETA: Unknown

@Dartis4 Dartis4 removed the 2 weeks inactive An issue that has not been updated by an assignee for two weeks label Jun 1, 2024
@github-actions github-actions bot added the To Update ! No update has been provided label Jun 14, 2024

This comment has been minimized.

@Dartis4 Dartis4 removed the To Update ! No update has been provided label Jun 15, 2024
@Dartis4
Copy link
Member

Dartis4 commented Jun 15, 2024

Progress: I believe this issue should be split into two separate issues and close this issue. The two new issues should be one focused on GitHub Actions unit testing, the other on frontend unit testing.
Blockers: None
Availability: 10am - 5pm
ETA: End of this week

@github-actions github-actions bot added the To Update ! No update has been provided label Jun 22, 2024
Copy link

@Dartis4

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures (optional): "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the Questions/In Review column of the Project Board and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. Please note that including your questions in the issue comments- along with screenshots, if applicable- will help us to help you. Here and here are examples of well-formed questions.

You are receiving this comment because your last comment was before Wednesday, June 19, 2024 at 1:48 PM PST.

@ExperimentsInHonesty ExperimentsInHonesty moved this to In progress (actively working) in P: HfLA Website: Project Board Jun 23, 2024
@Dartis4 Dartis4 removed the To Update ! No update has been provided label Jul 7, 2024
@Dartis4 Dartis4 removed their assignment Jul 7, 2024
@Dartis4 Dartis4 moved this from In progress (actively working) to Emergent Requests in P: HfLA Website: Project Board Jul 7, 2024
@Dartis4 Dartis4 moved this from Emergent Requests to New Issue Approval in P: HfLA Website: Project Board Jul 7, 2024
@Dartis4 Dartis4 moved this from New Issue Approval to Prioritized backlog in P: HfLA Website: Project Board Jul 7, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from Prioritized backlog to ERs and epics that are ready to be turned into issues in P: HfLA Website: Project Board Jul 12, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from ERs and epics that are ready to be turned into issues to Prioritized backlog in P: HfLA Website: Project Board Jul 12, 2024
@roslynwythe
Copy link
Member

roslynwythe commented Jul 28, 2024

@roslynwythe
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Large Feature: Infrastructure For changes on site technical architecture role: back end/devOps Tasks for back-end developers size: 2pt Can be done in 7-12 hours
Projects
Development

No branches or pull requests

8 participants