-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update how 'Overview' link opens for LA TDM Calculator #2242
Comments
Reopening this as the PR #2772 which is supposed to fix this issue isn't merged yet. |
@blulady In response to #2683 (comment),
Are you trying to push changes for the branch |
Progress: I need to be able to push the correct code up to github |
C:\Users\ssang\Documents\hackforla\website\assets\pdfs>git push
|
@blulady When you run the command
|
origin https://github.com/blulady/website.git (fetch) |
It looks like you are in "C:\Users\ssang\Documents\hackforla\website\assets\pdfs". Does changing to "C:\Users\ssang\Documents\hackforla\website" make a difference when you try to push? |
@blulady Just wanted to check if you still have the error log that we received after |
Overview
As a user, clicking on the 'Overview' link for the LA TDM Calculator project should open a new tab to the pdf file directly. This is made as an action item of #2211
Details
When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.
Example:
How LA TDM Calculator's pdf file currently opens
How it should open
Action Items
Resources/Instructions
Markdown file
Project Page
Location for pdf files
Jekyll Static Files
The text was updated successfully, but these errors were encountered: