Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how 'Overview' link opens for LA TDM Calculator #2242

Closed
3 tasks
Tracked by #2211
macho-catt opened this issue Sep 8, 2021 · 9 comments · Fixed by #2772
Closed
3 tasks
Tracked by #2211

Update how 'Overview' link opens for LA TDM Calculator #2242

macho-catt opened this issue Sep 8, 2021 · 9 comments · Fixed by #2772
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Sep 8, 2021

Overview

As a user, clicking on the 'Overview' link for the LA TDM Calculator project should open a new tab to the pdf file directly. This is made as an action item of #2211

Details

When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.

Example:
How LA TDM Calculator's pdf file currently opens
How it should open

Action Items

  • Download a copy of LA TDM Calculator's overview pdf and put it in /assets/pdfs
  • Change the 'Overview' link for the markdown file to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the project page and the project's dedicated page open the pdf file properly after the change

Resources/Instructions

Markdown file
Project Page
Location for pdf files
Jekyll Static Files

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@macho-catt macho-catt changed the title Change the 'Overview' link for LA TDM Calculator project to open as a pdf file in the browser instead of opening a github page that hosts the pdf file Update how 'Overview' link opens for LA TDM Calculator Sep 8, 2021
@macho-catt macho-catt added Feature: Refactor HTML Ready for Prioritization role: front end Tasks for front end developers Size: Good second issue and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@blulady blulady self-assigned this Feb 13, 2022
@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Feb 18, 2022
@blulady blulady closed this as completed Feb 20, 2022
@SAUMILDHANKAR
Copy link
Member

Reopening this as the PR #2772 which is supposed to fix this issue isn't merged yet.

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 4, 2022

@blulady In response to #2683 (comment),

Progress: I need to be able to push the correct code up to github Blockers: struggling with pushing a specific branch Availability: I have 8 hours to work on this ETA: as soon as I hear back Pictures: I haven't been able to make any changes

Are you trying to push changes for the branch update-how-overview-link-opens-for-LA-TDM-Calculator_2242? I'm asking because I'm trying to better understand the problem/blocker you are encountering.

@blulady
Copy link
Member

blulady commented Mar 4, 2022

Progress: I need to be able to push the correct code up to github
Blockers: struggling with pushing a specific branch
Availability: I have 8 hours to work on this
ETA: as soon as I hear back
Pictures: I haven't been able to make any changes

@blulady
Copy link
Member

blulady commented Mar 6, 2022

  1. from github repository website branch gh-pages click fetch upstream

  2. on local repository website branch gh-pages cli git fetch upstream

  3. on local repository git checkout update-how-overview-link-opens-for-LA-TDM-Calculator_2242 branch

  4. fetch from origin (for some reason the tdm pdf was in my github repo but not the local one)
    still not on the local in pycharm but can see it in cli
    5.because I can see it in cli, I attempt to push it
    git push --set-upstream origin update-how-overview-link-opens-for-LA-TDM-Calculator_2242
    git says "Everything up-to-date"
    'update-how-overview-link-opens-for-LA-TDM-Calculator_2242' set up to track remote branch 'update-how-overview-link-opens-for-LA-TDM-Calculator_2242' from 'origin'.

  5. then i attempt to update the local clone/fork
    git checkout upstream-gh-pages
    git pull
    git checkout gh-pages
    git merge upstream-gh-pages

  6. git push *here is where I get an error.

C:\Users\ssang\Documents\hackforla\website\assets\pdfs>git push
fatal: The current branch gh-pages has no upstream branch.
To push the current branch and set the remote as upstream, use

git push --set-upstream origin gh-pages

@JessicaLucindaCheng
Copy link
Member

JessicaLucindaCheng commented Mar 6, 2022

@blulady When you run the command git remote -v, do you get the following on your terminal?

origin  https://github.com/blulady/website.git (fetch)
origin  https://github.com/blulady/website.git (push)
upstream        https://github.com/hackforla/website.git (fetch)
upstream        https://github.com/hackforla/website.git (push)

@JessicaLucindaCheng
Copy link
Member

@blulady

C:\Users\ssang\Documents\hackforla\website\assets\pdfs>git push
fatal: The current branch gh-pages has no upstream branch.
To push the current branch and set the remote as upstream, use

git push --set-upstream origin gh-pages

It looks like you are in "C:\Users\ssang\Documents\hackforla\website\assets\pdfs". Does changing to "C:\Users\ssang\Documents\hackforla\website" make a difference when you try to push?

@JessicaLucindaCheng JessicaLucindaCheng added the size: 0.5pt Can be done in 3 hours or less label Mar 7, 2022
@blulady
Copy link
Member

blulady commented Mar 7, 2022

Screenshot (59)

@SAUMILDHANKAR
Copy link
Member

@blulady Just wanted to check if you still have the error log that we received after git push --set-upstream origin gh-pages during our last meeting. Please let me know. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

5 participants