Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how 'Overview' link opens for Engage #2239

Closed
3 tasks done
Tracked by #2211
macho-catt opened this issue Sep 8, 2021 · 3 comments · Fixed by #2734
Closed
3 tasks done
Tracked by #2211

Update how 'Overview' link opens for Engage #2239

macho-catt opened this issue Sep 8, 2021 · 3 comments · Fixed by #2734
Assignees
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@macho-catt
Copy link
Member

macho-catt commented Sep 8, 2021

Overview

As a user, clicking on the 'Overview' link for the Engage project should open a new tab to the pdf file directly. This is made as an action item of #2211

Details

When clicking the 'Overview' link, each project page acts differently. Some open to a google docs page, others open to a github page that hosts the pdf file, and another downloads the pdf file locally to the machine. There needs to be a standard in how the pdf files open. Developers decided during the backend meeting that pdfs should be opened as a separate tab to the file directly, since modern browsers have the ability to view pdfs.

Example:
How Engage's pdf file currently opens
How it should open

Action Items

  • Download a copy of Engage's overview pdf and put it in /assets/pdfs
  • Change the 'Overview' link for the markdown file to point to the pdf file living under /assets/pdfs
  • Ensure that the links in both the project page and the project's dedicated page open the pdf file properly after the change

Resources/Instructions

Markdown file
Project Page
Location for pdf files
Jekyll Static Files

@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@macho-catt macho-catt changed the title Change the 'Overview' link for Engage project to open as a pdf file in the browser instead of opening a github page that hosts the pdf file Update how 'Overview' link opens for Engage Sep 8, 2021
@macho-catt macho-catt added Feature: Refactor HTML role: front end Tasks for front end developers Size: Good second issue Ready for Prioritization and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Sep 8, 2021
@BrianCodes33 BrianCodes33 self-assigned this Feb 1, 2022
@BrianCodes33
Copy link
Contributor

BrianCodes33 commented Feb 2, 2022

Is there a reason why there are two .pdf extensions at the end of the file name? Don't think I've ever seen that. I also changed the markdown fiile, and it's still linking to Github for some reason.

here is the code i edited in md file: url: '../assets/pdfs/Engage-Product-One-Sheet.pdf.pdf'

@BrianCodes33
Copy link
Contributor

Availability for this week: Evenings M-F
ETA: 2-3 Days

@JessicaLucindaCheng
Copy link
Member

@BrianCodes33

Is there a reason why there are two .pdf extensions at the end of the file name? Don't think I've ever seen that. I also changed the markdown fiile, and it's still linking to Github for some reason.

here is the code i edited in md file: url: '../assets/pdfs/Engage-Product-One-Sheet.pdf.pdf'

  • Good catch! The name of the file should be Engage-Product-One-Sheet.pdf. Once you download the file, you can rename it so it only has one .pdf extension.
  • If you make changes to code and don't see it when you use Docker to view the website locally on your computer, run docker-compose down, then clear your cache and delete the file .jekyll-metadata and the directory _site, and then run docker-compose up. You should see changes locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor HTML good first issue Good for newcomers role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

5 participants