-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust "...See More" placement on Wins Cards #2207
Comments
Hi @kristine-eudey. Good job adding the required labels to this issue. Just a friendly reminder to also move the issue into the "New Issue Approval" column under the Project Board. For more info on that, check Github's documentation here. Additional Resources: |
Progress: Just assigned, not started |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, September 14, 2021 at 12:02 AM PST. |
Progress: Not started |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST. |
@kristine-eudey I've completed three options in the blue box to the right, ready for review! This may be a separate issue for once this page goes to development, but I did want to note that the card rows probably won't line up perfectly as they do in the initial page design unless we decide to standardize the card size and leave room for 2 rows of icons always, or limit to one row before expanding. Unless we're okay with the rows not perfectly aligning (which shows in my adjusted version. I don't think it's bad, just definitely a different look than the initial page where two icon row cards never fall next to a single icon row card). |
As decided at 9/26 team meeting, we'll move forward with Option A for the desktop version and Option B for mobile version and is ready for development.
|
Created #2339 to complete dev portion of this issue. |
Overview
We need to move the "...see more" link on the Wins cards from the end of the text to the bottom right of the card in order to standardize card design, making the design and functionality the same regardless of whether the cards do or do not have expandable text.
Action Items
Design:
Development:
Resources/Instructions
Wins Page
Figma - Wins Page
#2135 for further context on this issue
The text was updated successfully, but these errors were encountered: