-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the wins expanded icon styling in tablet view #2176
Comments
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, September 28, 2021 at 12:02 AM PST. |
Progress: Researched the tablet classes, icons, and breakpoint variables. Reviewed figma file. |
Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.
If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, October 12, 2021 at 12:02 AM PST. |
Progress: Created a pull request with changes. |
Overview
We need to refactor the expanded wins cards in tablet view so we can have a consistent view of the wins icons within the wins card.
This is a CSS problem that is a little harder than the average medium issue.
Click here to see the current wins page card
Here is the figma (for mobile. does not have tablet view)
click for screenshot
Action Items
Resources
https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/pages/wins/wins-card-template.html
https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/_sass/components/_wins-page.scss
https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/pages/wins/wins.html
The text was updated successfully, but these errors were encountered: