Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the wins expanded icon styling in tablet view #2176

Closed
2 tasks done
Tracked by #2135
jbubar opened this issue Aug 25, 2021 · 5 comments · Fixed by #2340
Closed
2 tasks done
Tracked by #2135

fix the wins expanded icon styling in tablet view #2176

jbubar opened this issue Aug 25, 2021 · 5 comments · Fixed by #2340
Assignees
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing To Update ! No update has been provided
Milestone

Comments

@jbubar
Copy link
Member

jbubar commented Aug 25, 2021

Overview

We need to refactor the expanded wins cards in tablet view so we can have a consistent view of the wins icons within the wins card.

This is a CSS problem that is a little harder than the average medium issue.

Click here to see the current wins page card

Screen Shot 2021-08-19 at 10 25 40 PM

Here is the figma (for mobile. does not have tablet view)

click for screenshot

Screen Shot 2021-08-24 at 7 50 34 PM

Action Items

  • Figure how the icons are styled.
    • which classes are associated with which styles and etc
  • rewrite a lot of the css for the icons so that it looks like the figma

Resources

https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/pages/wins/wins-card-template.html
https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/_sass/components/_wins-page.scss
https://github.com/hackforla/website/blob/c6358c0698a5356b63a0d8e76f186f11e902f400/pages/wins/wins.html

@jbubar jbubar mentioned this issue Aug 25, 2021
11 tasks
@github-actions github-actions bot added Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing labels Aug 25, 2021
@jbubar jbubar added Complexity: Large Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. role missing size: missing Complexity: Large labels Aug 25, 2021
@abuna1985 abuna1985 added Ready for Prioritization and removed Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages labels Aug 29, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Sep 5, 2021
@adrian-zaragoza adrian-zaragoza self-assigned this Sep 19, 2021
@github-actions github-actions bot added the To Update ! No update has been provided label Sep 24, 2021
@github-actions
Copy link

@adrian-zaragoza

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 21, 2021 at 12:02 AM PST.

@github-actions github-actions bot removed the To Update ! No update has been provided label Oct 1, 2021
@github-actions
Copy link

github-actions bot commented Oct 1, 2021

@adrian-zaragoza

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, September 28, 2021 at 12:02 AM PST.

@github-actions github-actions bot added the To Update ! No update has been provided label Oct 1, 2021
@adrian-zaragoza
Copy link
Member

Progress: Researched the tablet classes, icons, and breakpoint variables. Reviewed figma file.
Blockers: None.
Availability: I won't be available much this week to work on it. I will have more time on Monday.
ETA: Friday, Oct 8

@github-actions github-actions bot added Status: Updated No blockers and update is ready for review To Update ! No update has been provided and removed To Update ! No update has been provided Status: Updated No blockers and update is ready for review labels Oct 8, 2021
@github-actions
Copy link

@adrian-zaragoza

Please add update using the below template (even if you have a pull request). Afterwards, remove the 'To Update !' label and add the 'Status: Updated' label.

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) place your issue in the developer meeting discussion column and ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, October 12, 2021 at 12:02 AM PST.

@adrian-zaragoza
Copy link
Member

Progress: Created a pull request with changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing To Update ! No update has been provided
Projects
Development

Successfully merging a pull request may close this issue.

5 participants