Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Wins Data: Migrating from AF to KVF data structure #2146

Closed
5 tasks done
Tracked by #2147
Aveline-art opened this issue Aug 20, 2021 · 3 comments · Fixed by #2380
Closed
5 tasks done
Tracked by #2147

Migrate Wins Data: Migrating from AF to KVF data structure #2146

Aveline-art opened this issue Aug 20, 2021 · 3 comments · Fixed by #2380
Assignees
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Aug 20, 2021

### Dependency
#2145

Overview

As a developer, to turn the wins card into a reusable component, we must first be able to generate a wins-data.json file of a more specific format. This issue is part of a series that aims to migrate us to the more specific format.

Action Items

  • Read the resources/instructions below to understand your task.
  • Find areas in our codebase where we are using the AF version of the file (currently it is only the wins-page, but that might change by the time this issue is assigned).
  • Change all uses of the AF version to the KVF version.
  • Change code as needed to ensure the website still functions the same way. This means there are no visual changes to the website.
  • Release dependency on Google Apps Script: Migrate Wins Data - Stop generation of AF file #2147

Resources/Instructions

wins-page

Currently we have two json files for wins: _wins-data.json and wins-data.json. The former will henceforth be called KVF (for key-value file) and AF (for array file). AF is generated daily from a script on google while KVF appears to be an older, dysfunc version. The format in the KVF version, however, is much friendlier to formatting in liquid syntax. Therefore, we need to incrementally port our codebase to use the KVF version of the data and remove the AF version we currently use. This will be done in multiple steps:

  1. Have the apps script generate both AF and KVF version.
  2. Migrate all uses of AF to KVF.
  3. Have the apps script stop generating the AF version.
  4. Delete the AF version from our repo since it is now unused.

For this issue, we are doing step 2.

@Aveline-art Aveline-art added role: back end/devOps Tasks for back-end developers Complexity: Medium Dependency An issue is blocking the completion or starting of another issue P-Feature: Wins Page https://www.hackforla.org/wins/ labels Aug 20, 2021
@github-actions

This comment has been minimized.

@macho-catt macho-catt removed the Dependency An issue is blocking the completion or starting of another issue label Oct 8, 2021
@macho-catt macho-catt self-assigned this Oct 8, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot added the To Update ! No update has been provided label Oct 15, 2021
@macho-catt macho-catt removed the To Update ! No update has been provided label Oct 17, 2021
@macho-catt
Copy link
Member

Progress: I have an idea of what I need to remove so we can completely transfer to the new file
Blockers: None
Availability: 2 hrs
ETA: Next week
Pictures: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: back end/devOps Tasks for back-end developers size: missing Status: Updated No blockers and update is ready for review
Projects
Development

Successfully merging a pull request may close this issue.

4 participants