Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply design system heading classes to Project Team Meetings page #2089

Closed
4 tasks done
kristine-eudey opened this issue Aug 10, 2021 · 3 comments · Fixed by #3008
Closed
4 tasks done

Apply design system heading classes to Project Team Meetings page #2089

kristine-eudey opened this issue Aug 10, 2021 · 3 comments · Fixed by #3008
Assignees
@RyanCahela
Labels
Feature: Design system good first issue Good for newcomers P-Feature: Project Meetings https://www.hackforla.org/project-meetings role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Milestone
w. Accessibility

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 10, 2021 •
edited by RyanCahela
Loading

Overview

We need to apply the new standardized heading classes to the Project Team Meetings page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.

Action Items

  • Apply the heading class (“.Title3”) noted in the screenshot below to the Project Team Meetings page
    • “.Title3" class for the day-of-week subheadings in the meeting times page card (Monday, Tuesday, etc)
  • Make sure the headings with the new classes look good both in mobile and desktop, and that nothing gets messed up due to these changes
  • If needed, adjust the heading h tags (h3 etc.) so that they reflect the correct hierarchy of the page for screen readers (since the styling no longer relies on the h tags)

Resources/Instructions

Project Team Meetings page
Screen Shot 2021-08-08 at 12 23 58 AM
@Aveline-art

This comment has been minimized.

Sign in to view
@kristine-eudey

This comment has been minimized.

Sign in to view
@kristine-eudey kristine-eudey mentioned this issue Aug 22, 2021
Closed
4 tasks
@SAUMILDHANKAR SAUMILDHANKAR mentioned this issue Aug 22, 2021
Open
17 tasks
@ExperimentsInHonesty ExperimentsInHonesty added this to the z. Accessibility milestone Aug 30, 2021
@ExperimentsInHonesty ExperimentsInHonesty added the P-Feature: Project Meetings https://www.hackforla.org/project-meetings label Sep 15, 2021
@JessicaLucindaCheng JessicaLucindaCheng added the size: 0.5pt Can be done in 3 hours or less label Mar 7, 2022
@RyanCahela RyanCahela self-assigned this Mar 24, 2022
@RyanCahela
Copy link
Member

ETA: 3 Hours or less.
Availability: 12 (Noon) - 5PM 03/24/22

@RyanCahela RyanCahela mentioned this issue Mar 24, 2022
Merged
@github-actions github-actions bot added the Status: Updated No blockers and update is ready for review label Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanCahela RyanCahela

Labels
Feature: Design system good first issue Good for newcomers P-Feature: Project Meetings https://www.hackforla.org/project-meetings role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less Status: Updated No blockers and update is ready for review
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
w. Accessibility
Development

Successfully merging a pull request may close this issue.

Applied "title3" Classes to Headings.
6 participants
@RyanCahela @kristine-eudey @abuna1985 @JessicaLucindaCheng @ExperimentsInHonesty @Aveline-art