Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply design system heading classes to Program Areas page #2088

Closed
4 tasks done
kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2779
Closed
4 tasks done

Apply design system heading classes to Program Areas page #2088

kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2779
Assignees
@Carlos-A-P
Labels
Feature: Design system good first issue Good for newcomers P-Feature: Program Area https://www.hackforla.org/program-areas role: front end Tasks for front end developers size: missing
Milestone
w. Accessibility

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 10, 2021 •
edited by Carlos-A-P
Loading

Overview

We need to apply the new standardized heading classes to the Program Areas page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.

Action Items

  • Apply the heading class (“.Title4”) noted in the screenshot below to the Program Areas page
    • “.Title4" class for the headings in the page cards (“Citizen Engagement,” “Civic Tech Infrastructure,” etc)
  • Make sure the headings with the new classes look good both in mobile and desktop, and that nothing gets messed up due to these changes
  • If needed, adjust the heading h tags (h3 etc.) so that they reflect the correct hierarchy of the page for screen readers (since the styling no longer relies on the h tags)

Resources/Instructions

Program Areas page
Screen Shot 2021-08-08 at 12 29 11 AM
@kristine-eudey kristine-eudey added role: front end Tasks for front end developers P-Feature: Program Area https://www.hackforla.org/program-areas Size: Good second issue Feature: Design system labels Aug 10, 2021
@kevngaleu kevngaleu added this to the z. Accessibility milestone Aug 18, 2021
@Carlos-A-P Carlos-A-P self-assigned this Feb 14, 2022
@Carlos-A-P
Copy link
Member

Availability for this week: 4 hrs
My estimated ETA for completing this issue: 2/17/22 Thursday

@Carlos-A-P Carlos-A-P mentioned this issue Feb 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carlos-A-P Carlos-A-P

Labels
Feature: Design system good first issue Good for newcomers P-Feature: Program Area https://www.hackforla.org/program-areas role: front end Tasks for front end developers size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
w. Accessibility
Development

Successfully merging a pull request may close this issue.

Apply heading class to Program Areas Page
6 participants
@kristine-eudey @ExperimentsInHonesty @macho-catt @kevngaleu @Carlos-A-P @Josiah-O