Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply design system heading classes to Toolkit page #2086

Closed
3 tasks done
kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2803
Closed
3 tasks done

Apply design system heading classes to Toolkit page #2086

kristine-eudey opened this issue Aug 10, 2021 · 1 comment · Fixed by #2803
Assignees
@Carlos-A-P
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: missing
Milestone
w. Accessibility

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 10, 2021 •
edited by Carlos-A-P
Loading

Overview

We need to apply the new standardized heading classes to the Toolkit page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.

Action Items

  • Apply the heading classes noted in the Toolkit page Figma file (in pink rectangle) to the Toolkit page
  • Make sure the headings still look good and correct (same as the Figma) both in mobile and desktop, and that nothing gets messed up due to these changes
  • Make sure to adjust the heading h tags if needed so that they reflect the correct hierarchy of the page for screen readers (since the styling no longer relies on the h tags)

Resources/Instructions

Toolkit page Figma file (in pink rectangle)
Toolkit page
From Figma:
Screen Shot 2021-08-08 at 1 47 36 AM
@kristine-eudey kristine-eudey added role: front end Tasks for front end developers P-Feature: Toolkit https://www.hackforla.org/toolkit/ Feature: Design system Complexity: Small Take this type of issues after the successful merge of your second good first issue labels Aug 10, 2021
@sheltoG sheltoG added this to the z. Accessibility milestone Aug 18, 2021
@Carlos-A-P Carlos-A-P self-assigned this Feb 19, 2022
@Carlos-A-P
Copy link
Member

Availability for this week: 6hrs
My estimated ETA for completing this issue: 1 week

@Carlos-A-P Carlos-A-P mentioned this issue Feb 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Carlos-A-P Carlos-A-P

Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Design system P-Feature: Toolkit https://www.hackforla.org/toolkit/ role: front end Tasks for front end developers size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
w. Accessibility
Development

Successfully merging a pull request may close this issue.

applied title3 class to h2 tags
5 participants
@kristine-eudey @sheltoG @macho-catt @Carlos-A-P @Josiah-O