-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply design system heading classes to Wins page #2082
Comments
@adrian-zaragoza please close #2150 and create a new branch that splits from |
Please add update using this template (even if you have a pull request)
If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel. You are receiving this comment because your last comment was before Tuesday, August 24, 2021 at 12:03 AM PST. |
Hi @abuna1985 , I created the new PR 2189 to merge my changes with the wins-feature-1 branch. Let me know if I need to do anything else. |
Thank you @adrian-zaragoza. My apologies for not catching this earlier. |
@adrian-zaragoza please close this if this is done. I think this is happening because a linked PR was closed, rather than merged. When this happens, the linked issue does not close, but it does go into UAT. When closing (rather than merging) reviews, please remove the linked issue in the PR. |
Closing this issue because its complete. |
Overview
We need to apply the new standardized heading classes to the Wins page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.
Action Items
Resources/Instructions
Wins page
Guide to working on a feature branch (wins-feature-1)
The text was updated successfully, but these errors were encountered: