Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply design system heading classes to Wins page #2082

Closed
2 tasks done
kristine-eudey opened this issue Aug 10, 2021 · 6 comments · Fixed by #2189
Closed
2 tasks done

Apply design system heading classes to Wins page #2082

kristine-eudey opened this issue Aug 10, 2021 · 6 comments · Fixed by #2189
Assignees
Labels
Feature: Design system Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages good first issue Good for newcomers P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing To Update ! No update has been provided UAT: has visuals

Comments

@kristine-eudey
Copy link
Member

kristine-eudey commented Aug 10, 2021

Overview

We need to apply the new standardized heading classes to the Wins page headings (for accessibility/to remove the styling reliance on h tags), so that that the page can now follow the design system plan and be more accessible.

Action Items

  • Apply the heading class “.title1” to the Wins page header’s heading text (“Let’s celebrate together!“)
  • Make sure the heading still looks the same as it did before in mobile and desktop, and that nothing gets messed up due to these changes

Resources/Instructions

Wins page
Guide to working on a feature branch (wins-feature-1)
Screen Shot 2021-08-08 at 1 11 22 AM

@abuna1985
Copy link
Member

@adrian-zaragoza please close #2150 and create a new branch that splits from wins-feature-1 instead of gh-pages. I added Guide to working on a feature branch (wins-feature-1) in the resources section of the issue. Then push changes to the newly made branch and create a new pull request.

@abuna1985 abuna1985 added the Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages label Aug 27, 2021
@github-actions github-actions bot added the To Update ! No update has been provided label Aug 27, 2021
@github-actions
Copy link

@adrian-zaragoza

Please add update using this template (even if you have a pull request)

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures: "Add any pictures of the visual changes made to the site so far."

If you need help, be sure to either: 1) ask for help at your next meeting, 2) put a "Status: Help Wanted" label on your issue and pull request, or 3) put up a request for assistance on the #hfla-site channel.

You are receiving this comment because your last comment was before Tuesday, August 24, 2021 at 12:03 AM PST.

@adrian-zaragoza
Copy link
Member

Hi @abuna1985 , I created the new PR 2189 to merge my changes with the wins-feature-1 branch. Let me know if I need to do anything else.

@abuna1985
Copy link
Member

Thank you @adrian-zaragoza. My apologies for not catching this earlier.

@abuna1985 abuna1985 linked a pull request Aug 29, 2021 that will close this issue
@Aveline-art
Copy link
Member

Aveline-art commented Aug 29, 2021

@adrian-zaragoza please close this if this is done. I think this is happening because a linked PR was closed, rather than merged. When this happens, the linked issue does not close, but it does go into UAT. When closing (rather than merging) reviews, please remove the linked issue in the PR.

@adrian-zaragoza
Copy link
Member

Closing this issue because its complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Design system Feature: Feature Branch Requires Branching off a Feature Branch instead of gh-pages good first issue Good for newcomers P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing To Update ! No update has been provided UAT: has visuals
Projects
8 participants