Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wins-feature-1: Badges container penetrates background of fixed menu #1717

Closed
4 tasks done
Aveline-art opened this issue Jun 12, 2021 · 2 comments · Fixed by #1897
Closed
4 tasks done

wins-feature-1: Badges container penetrates background of fixed menu #1717

Aveline-art opened this issue Jun 12, 2021 · 2 comments · Fixed by #1897
Assignees
@marcobarrera
Labels
Bug Something isn't working Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Milestone
05. Know HFLA

Comments

@Aveline-art
Copy link
Member

Aveline-art commented Jun 12, 2021 •
edited by marcobarrera
Loading

Overview

In our wins-feature-1 branch of the website project, when the badges container is expanded in mobile (or when then .wins-page-tablet class is added), the container somehow "penetrates" the background of the menu. Below is a sample of such behavior: note that "I setup 2FA" appears on the fixed menu.

Image of bug

This should not happen--the menu should remain solid throughout.

Action Items

Resources/Instructions

How to work off of a feature branch
wins-feature-1 branch of website project
@Aveline-art Aveline-art added Bug Something isn't working P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: good second issue labels Jun 12, 2021
@Sihemgourou Sihemgourou added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 12, 2021
@marcobarrera marcobarrera self-assigned this Jun 19, 2021
@Sihemgourou Sihemgourou added the To Update ! No update has been provided label Jun 28, 2021
@github-actions
Copy link

@marcobarrera Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou Sihemgourou removed the To Update ! No update has been provided label Jun 28, 2021
@marcobarrera marcobarrera self-assigned this Jul 7, 2021
@marcobarrera marcobarrera mentioned this issue Jul 7, 2021
Merged
@abuna1985 abuna1985 linked a pull request Jul 9, 2021 that will close this issue
Fixed wins modal position to prevent it from penetrating menu in mobile #1897
Merged
Closed
15 tasks
@Abel-Zambrano
Copy link
Contributor

IMPORTANT!!
This issue is working off of a feature branch!
Please follow this wiki before creating a new branch!
how to work off a feature branch

@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcobarrera marcobarrera

Labels
Bug Something isn't working Complexity: Medium P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
05. Know HFLA
Development

Successfully merging a pull request may close this issue.

Fixed wins modal position to prevent it from penetrating menu in mobile marcobarrera/website
6 participants
@marcobarrera @ExperimentsInHonesty @Sihemgourou @Aveline-art @Abel-Zambrano @Josiah-O