Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust margin in mobile Wins page header #1594

Closed
1 task done
daniellex0 opened this issue May 20, 2021 · 4 comments
Closed
1 task done

Adjust margin in mobile Wins page header #1594

daniellex0 opened this issue May 20, 2021 · 4 comments
Assignees
@MariannaAskova
Labels
good first issue Good for newcomers P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Milestone
05. Know HFLA

Comments

@daniellex0
Copy link
Member

daniellex0 commented May 20, 2021 •
edited by MariannaAskova
Loading

Overview

We need to make the margin smaller between the heading and button in the Wins page in mobile, to make the header look less distorted.

Action Items

  • Decrease the margin in the Wins page header between the heading ("Let's celebrate together!) and button ("Share your wins") to 32px (instead of 56px)

Resources/Instructions

Wins page
Hack for LA site architecture

How it looks now (incorrect):

Screen Shot 2021-05-19 at 11 57 12 PM

How it should look (correct):

Screen Shot 2021-05-19 at 11 57 26 PM
@daniellex0 daniellex0 added role: front end Tasks for front end developers size: good second issue P-Feature: Wins Page https://www.hackforla.org/wins/ labels May 20, 2021
@Sihemgourou
Copy link
Contributor

@daniellex0
Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou Sihemgourou added Status: Updated No blockers and update is ready for review To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Jun 9, 2021
@daniellex0 daniellex0 removed the To Update ! No update has been provided label Jun 11, 2021
@daniellex0
Copy link
Member Author

Hey @Sihemgourou btw this issue is in the Prioritized Backlog and hasn't been assigned yet, so there's no update until someone self-assigns it :)

@Sihemgourou Sihemgourou added good first issue Good for newcomers and removed good first issue Good for newcomers labels Jun 12, 2021
@Linda-OC Linda-OC self-assigned this Jun 16, 2021
@Sihemgourou Sihemgourou added the To Update ! No update has been provided label Jun 28, 2021
@github-actions
Copy link

@Linda-OC Please add update

  1. Progress
  2. Blockers
  3. Availability
  4. ETA

@Sihemgourou Sihemgourou removed the To Update ! No update has been provided label Jul 4, 2021
@MariannaAskova MariannaAskova self-assigned this Jul 8, 2021
This was referenced Jul 12, 2021
Closed
Merged
@jbubar
Copy link
Member

jbubar commented Jul 14, 2021

IMPORTANT!!
This issue is working off of a feature branch!
Please follow this wiki before creating a new branch!
how to work off a feature branch

@ExperimentsInHonesty ExperimentsInHonesty added this to the 05. Know HFLA milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MariannaAskova MariannaAskova

Labels
good first issue Good for newcomers P-Feature: Wins Page https://www.hackforla.org/wins/ role: front end Tasks for front end developers size: missing
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
05. Know HFLA
Development

Successfully merging a pull request may close this issue.

Changed margin to 32px on mobile Wins page hero MariannaAskova/website
8 participants
@ExperimentsInHonesty @arghmatey @jbubar @Sihemgourou @Linda-OC @daniellex0 @MariannaAskova @Josiah-O