Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Alt Text for Partnership Icon on Credit page #1576

Closed
1 task
qiqicodes opened this issue May 17, 2021 · 3 comments · Fixed by #1783
Closed
1 task

Change Alt Text for Partnership Icon on Credit page #1576

qiqicodes opened this issue May 17, 2021 · 3 comments · Fixed by #1783
Assignees
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers size: missing

Comments

@qiqicodes
Copy link
Member

qiqicodes commented May 17, 2021

Overview

Alt text for Partnership Icon on Credit Page needs update.

Action Items

  • Change the alt attribute value to 'Partnership Icon'
- alt: 'Image of Partnership'
+ alt: 'Partnership Icon'

Resources/Instructions

alt: 'Image of Partnership'

@qiqicodes qiqicodes added good first issue Good for newcomers Feature: Accessibility Issues that would broaden website accessibility labels May 17, 2021
@paulsvh paulsvh assigned paulsvh and unassigned paulsvh May 19, 2021
@benrempel
Copy link
Member

I fixed this locally, should I push now?

As far as I can tell, partnership.yml isn't referenced anywhere in the site. This same partnership icon is used in the "join us" page, but directly references the .svg file, with its own alt text. Is that an issue? Still getting a sense of the architecture.

<img class="join-us-card-img" src="/assets/images/join-us/partner-with-us-icon.svg" alt="join us card image" />

@jbubar
Copy link
Member

jbubar commented Jun 18, 2021

@benrempel Great question! yes go ahead and create a pr.

partnership.yml is part of a collection that gets referenced in the credits page with some fancy liquid jekyll syntaxy stuff

{%- for item in site.data.internal.credits -%}

and for the second question. I think they are supposed to be different, because they are on different pages.

but lets ask qiqi.

@qiqicodes want to weight in on this?

@benrempel
Copy link
Member

ah got it! I was trying to figure out where partership.yml was used in the site. Now I get what's going on- I think you're right and there's no issue here

@sayalikotkar sayalikotkar added the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@Sihemgourou Sihemgourou removed the Feature Missing This label means that the issue needs to be linked to a precise feature label. label Jun 20, 2021
@ExperimentsInHonesty ExperimentsInHonesty added this to the w. Accessibility milestone Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Accessibility Issues that would broaden website accessibility good first issue Good for newcomers size: missing
Projects
Development

Successfully merging a pull request may close this issue.

8 participants