Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New donation gif? #1146

Closed
3 tasks
jbubar opened this issue Mar 1, 2021 · 5 comments · Fixed by #1206
Closed
3 tasks

New donation gif? #1146

jbubar opened this issue Mar 1, 2021 · 5 comments · Fixed by #1206
Assignees
Labels
Complexity: Missing enhancement New feature or request suggestion Feature Missing This label means that the issue needs to be linked to a precise feature label. role: front end Tasks for front end developers size: missing

Comments

@jbubar
Copy link
Member

jbubar commented Mar 1, 2021

Overview

The current donation gif has some text to the right of it. I thought might want a new one.
here is the link the gif live on the events page of our site

current gif

image

new gif option

image

Action Items

  • Look through these gif options
  • Get product's or design's thought on this
  • create a new issue to replace it if we chose to do that

Resources/Instructions

REPLACE THIS TEXT -If there is a website which has documentation that helps with this issue provide the link(s) here.

@jbubar jbubar added the enhancement New feature or request suggestion label Mar 1, 2021
@akibrhast
Copy link
Member

@daniellex0 Should we replace it with the new gif provided by @jbubar ?

@daniellex0
Copy link
Member

daniellex0 commented Mar 7, 2021

@akibrhast Sure, and it looks like the donation form has a new section about repeated donations so this is great to update- thanks for doing that @jbubar !

@ExperimentsInHonesty just confirming this is fine to replace?

The only slight concern is that since this is a narrower image it might affect the formatting, but we can make adjustments to make sure everything is centered and looks good. FYI this gif currently exists in both the About Us page and the upcoming Join Us page.

@akibrhast akibrhast added the Status: Help Wanted Internal assistance is required to make progress label Mar 7, 2021
@Oluwafemi-Jegede
Copy link

Approved by @ExperimentsInHonesty

@Lol-Whut Lol-Whut self-assigned this Mar 7, 2021
@Lol-Whut
Copy link
Member

Lol-Whut commented Mar 7, 2021

I'm going to switch out the gifs and close the issue when completed

@Lol-Whut Lol-Whut added role: front end Tasks for front end developers and removed Status: Help Wanted Internal assistance is required to make progress labels Mar 7, 2021
@Lol-Whut
Copy link
Member

Progress: On my end, the gif is replaced and seems to be working, but I'm having trouble pushing changes; I'm thinking this is a git flow issue I'm encountering for the first time.
Blockers: I've made changes on my feature branch, but when I use the "git status" command, I get a "working tree clean" message. I've tried different methods of making these changes to see if my original method was the problem; at this point I would expect the HFLA-Donations.gif file and the about.html file that links to it to show up with changes to commit.
Availability: 4-5 hours
ETA: If I can figure out the issue, pushing changes will take a couple mins; hopefully researching the issue won't take tooo much more time.
Pictures: Current view of website on my end --

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Missing enhancement New feature or request suggestion Feature Missing This label means that the issue needs to be linked to a precise feature label. role: front end Tasks for front end developers size: missing
Projects
Development

Successfully merging a pull request may close this issue.

7 participants