Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize Project Meetings Page (SCSS) #1044

Closed
2 tasks
daniellex0 opened this issue Feb 14, 2021 · 7 comments · Fixed by #1288
Closed
2 tasks

Standardize Project Meetings Page (SCSS) #1044

daniellex0 opened this issue Feb 14, 2021 · 7 comments · Fixed by #1288
Assignees
@kevinreber
Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review

Comments

@daniellex0
Copy link
Member

Overview

We need to standardize the Project Meetings page so that it is has visual consistency with the rest of the HfLA website and our design system.

Action Items

  • Review the SCSS fixes on the Project Team Meetings page file on Figma (to the right, in large orange box)
  • Implement all of the fixes on the Project Team Meetings page's .scss file (_sass / components / _project-meetings.scss) and the few in its HTML file

Resources/Instructions

Project Meetings Figma file (notes to the right, in large orange box)
Current Project Meetings page

*The notes/scss edits I provided will hopefully help standardize the current Project Meetings page (mostly the header) and get it closer to the mockup version. Please let me know if you have any questions.
@daniellex0 daniellex0 added role: front end Tasks for front end developers Complexity: Medium labels Feb 14, 2021
@daniellex0
Copy link
Member Author

image

This part of the figma is not very clear, @daniellex0 can you please fix it?

Originally posted by @TeddyTelanoff in #1041 (comment)

So sorry @TeddyTelanoff , I just finally fixed this! Let me know if there are any other issues

@daniellex0
Copy link
Member Author

(Just FYI @TeddyTelanoff since you might get an alert, I deleted your comment about this on the Events page issue to avoid confusion)

@pawan92
Copy link

pawan92 commented Feb 21, 2021 •
edited by tarang100
Loading

@TeddyTelanoff Can you please add the labels for status?
Please refer to https://github.com/hackforla/website/wiki/Instructions-for-adding-Status-Labels-to-issues for understanding on how to add the status labels

@pawan92 pawan92 added the Status: Updated No blockers and update is ready for review label Feb 21, 2021
@jbubar
Copy link
Member

jbubar commented Feb 24, 2021

Teddy and I are going to go over this together tomorrow at 3pm

@akibrhast akibrhast added To Update ! No update has been provided and removed Status: Updated No blockers and update is ready for review labels Mar 2, 2021
@daniellex0 daniellex0 added Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages and removed To Update ! No update has been provided Feature: Refactor JS / Liquid Page is working fine - JS / Liquid needs changes to become consistent with other pages labels Mar 16, 2021
@kevinreber kevinreber self-assigned this Mar 19, 2021
@kevinreber
Copy link
Contributor

Progress

Added all styling listed in Figma mock up.

Blockers

There are some extra styles being applied that aren't mentioned in the Figma mock up. Consulting with @daniellex0 to see if these styles should be removed/modified.

Screenshots

Current

image

Figma Mockup

image

Availability

Wednesday Night, Thursday & Friday

ETA

End of week

@kevinreber kevinreber added Status: Help Wanted Internal assistance is required to make progress Status: Updated No blockers and update is ready for review labels Mar 21, 2021
@kevinreber kevinreber mentioned this issue Mar 21, 2021
Merged
@kevinreber
Copy link
Contributor

Progress
Received feedback from design, will have time to add updates later this week.

Blockers
Studying

Availability
evenings

ETA
End of week

@kevinreber kevinreber removed the Status: Help Wanted Internal assistance is required to make progress label Mar 24, 2021
@daniellex0 daniellex0 mentioned this issue Mar 24, 2021
Closed
7 tasks
@kevinreber
Copy link
Contributor

Progress

Added styling to match Join Page styling.
Waiting for feedback from design.

Desktop

Before

After

Tablet

Before

After

Mobile

Before

After

Blockers

Studying/Renovating

Availability

Evenings

ETA

End of week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinreber kevinreber

Labels
Complexity: Medium Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages role: front end Tasks for front end developers size: missing Status: Updated No blockers and update is ready for review
Projects
P: HfLA Website: Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardizing project meetings styles kevinreber/website
8 participants
@pawan92 @Treidexy @akibrhast @ExperimentsInHonesty @kevinreber @jbubar @daniellex0 @Josiah-O